Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud: Support create database locally #150858

Merged
merged 1 commit into from
Apr 19, 2022
Merged

nixos/nextcloud: Support create database locally #150858

merged 1 commit into from
Apr 19, 2022

Conversation

onny
Copy link
Contributor

@onny onny commented Dec 15, 2021 •
edited
Loading

Motivation for this change

This PR will add support for creating Mysql database locally using services.nextcloud.database.createLocally = true;.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 15, 2021
@onny onny marked this pull request as draft December 15, 2021 15:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 15, 2021
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Dec 16, 2021
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 16, 2021
@onny onny force-pushed the nextcloud branch 7 times, most recently from c7a4483 to ea71ba3 Compare April 16, 2022 15:05
@onny onny changed the title [DRAFT] nixos/nextcloud: Support create database locally nixos/nextcloud: Support create database locally Apr 16, 2022
@onny onny force-pushed the nextcloud branch 2 times, most recently from 161a831 to 79dd653 Compare April 16, 2022 15:06
@onny onny marked this pull request as ready for review April 16, 2022 15:08
@onny
Copy link
Contributor Author

onny commented Apr 16, 2022

@Ma27 I would like to use this feature, do you think it is possible to add this?

@onny onny requested a review from Ma27 April 16, 2022 15:13
@onny onny force-pushed the nextcloud branch 6 times, most recently from 61885c6 to 5bc0aee Compare April 16, 2022 15:20
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 16, 2022
@onny
Copy link
Contributor Author

onny commented Apr 16, 2022

Tests run fine now :)

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 17, 2022
@onny onny requested a review from davidak April 18, 2022 09:58
@onny onny requested a review from happysalada April 19, 2022 13:34
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 19, 2022
@happysalada
Copy link
Contributor

I don't have anything else to add.

@happysalada happysalada merged commit 047473a into NixOS:master Apr 19, 2022
Ma27
Ma27 reviewed May 18, 2022
View reviewed changes
nixos/modules/services/web-apps/nextcloud.nix
innodb_read_only_compressed = 0;
};
};
initialScript = pkgs.writeText "mysql-init" ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm why did we even add this? It's inconsistent to the ensure* thing and only runs on the very first install of mysql.

@Ma27 Ma27 mentioned this pull request Apr 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@aanderse aanderse Awaiting requested review from aanderse

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@davidak davidak Awaiting requested review from davidak

@happysalada happysalada Awaiting requested review from happysalada

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onny @happysalada @Ma27 @aanderse @SuperSandro2000