Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubergrunt: init at 0.7.11 #151509

Merged
merged 1 commit into from Dec 28, 2021
Merged

kubergrunt: init at 0.7.11 #151509

merged 1 commit into from Dec 28, 2021

Conversation

psibi
Copy link
Member

@psibi psibi commented Dec 21, 2021

This is a helper utility which allows to configure EKS clusters etc.

Tested it locally on a NixOS machine:

kubergrunt help
Usage: kubergrunt [--loglevel] [--help] command [options] [args]

A CLI tool to help setup and manage a Kubernetes cluster.

Commands:

   eks      Helper commands to configure EKS.
   k8s      Helper scripts for managing Kubernetes resources directly.
   tls      Helper commands to manage TLS certificate key pairs as Kubernetes Secrets.
   help, h  Shows a list of commands or help for one command
Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a few formatting suggestions for consistency with the rest of nixpkgs, functionality wise this LGTM 👍

Result of nixpkgs-review pr 151509 run on x86_64-linux 1

1 package built:
  • kubergrunt

@psibi
Copy link
Member Author

psibi commented Dec 27, 2021

@IvarWithoutBones Thanks for the feedback, addressed. Is there any tool which automatically does the formatting according to what's preferred in nixpkgs ? I used nixfmt (https://github.com/serokell/nixfmt) to do the initial formatting.

@IvarWithoutBones
Copy link
Member

Yes, There's nixpkgs-fmt (https://github.com/nix-community/nixpkgs-fmt) which helps out a lot.

Also, would you mind squashing the commits? Other than that, this PR looks good to me :)

This is a helper utility which allows to configure EKS clusters etc.

Tested it locally on a NixOS machine:

``` shellsession
❯ kubergrunt help
Usage: kubergrunt [--loglevel] [--help] command [options] [args]

A CLI tool to help setup and manage a Kubernetes cluster.

Commands:

   eks      Helper commands to configure EKS.
   k8s      Helper scripts for managing Kubernetes resources directly.
   tls      Helper commands to manage TLS certificate key pairs as Kubernetes Secrets.
   help, h  Shows a list of commands or help for one command
```
@psibi
Copy link
Member Author

psibi commented Dec 28, 2021

@IvarWithoutBones Thanks, done.

Copy link
Contributor

@legendofmiracles legendofmiracles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and prints help menu
LGTM

@legendofmiracles legendofmiracles merged commit f80ea94 into NixOS:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants