Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/wordpress: Drop old deprecated interface #152674

Merged
merged 2 commits into from
Jan 23, 2022

Conversation

onny
Copy link
Contributor

@onny onny commented Dec 30, 2021

Motivation for this change

This PR drops the old deprecated interface from the Wordpress module. The former syntax
services.wordpress."hostname.local" = {} changed to services.wordpress.sites."hostname.local" = {} with NixOS 21.11.
It would be good to drop the old deprecated interface with 22.05 to cleanup the module.
The deprecation warning was introduced with 21.11 and also noted in the release notes.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 30, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 30, 2021
@mweinelt mweinelt requested a review from mohe2015 January 7, 2022 16:05
nixos/tests/wordpress.nix Outdated Show resolved Hide resolved
@onny onny force-pushed the wordpresscleanup branch from 2e329f6 to c8c2ab3 Compare January 9, 2022 12:54
@onny onny requested review from eonpatapon and mohe2015 January 9, 2022 12:55
@onny onny force-pushed the wordpresscleanup branch from c8c2ab3 to 19510a9 Compare January 14, 2022 17:33
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Jan 14, 2022
@onny onny requested a review from eonpatapon January 14, 2022 17:36
@onny
Copy link
Contributor Author

onny commented Jan 14, 2022

Added some release notes about the removal of the old deprecated interface

@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 14, 2022
@onny onny force-pushed the wordpresscleanup branch from c361f06 to bc700b1 Compare January 20, 2022 10:51
@onny onny requested a review from eonpatapon January 20, 2022 10:53
@onny
Copy link
Contributor Author

onny commented Jan 20, 2022

Thank you @eonpatapon that was a good hint, fixed it :)

@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 20, 2022
@onny onny requested a review from happysalada January 23, 2022 13:34
@happysalada
Copy link
Contributor

Thank you!

@happysalada happysalada merged commit c95e816 into NixOS:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants