Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dokuwiki: Drop deprecated old interface #152676

Merged
merged 2 commits into from
Jan 15, 2022

Conversation

onny
Copy link
Contributor

@onny onny commented Dec 30, 2021

Motivation for this change

This PR drops the old deprecated interface used before NixOS 21.11. The syntax services.dokuwiki."hostname.local" was changed to services.dokuwiki.sites."hostname.local"`. A deprecation notice was added to the NixOS 21.11 release notes.
It would be good to drop the old interface to cleanup the Dokuwiki module with NixOS 22.05.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 30, 2021
@onny onny requested a review from 1000101 December 30, 2021 11:16
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 30, 2021
@onny onny requested review from dali99 and happysalada January 9, 2022 12:57
@happysalada
Copy link
Contributor

Should we not add a note in the release notes ?

@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Jan 14, 2022
@onny
Copy link
Contributor Author

onny commented Jan 14, 2022

Thanks for the review, added a note to the release notes

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 14, 2022
@happysalada
Copy link
Contributor

@NinjaTrappeur you were using this if I remember correcty. This looks good to me to merge.
I'm going to wait a couple more days in case you have time to have a look.

@picnoir
Copy link
Member

picnoir commented Jan 15, 2022 via email

@happysalada happysalada merged commit 75d417c into NixOS:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants