Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpp: init at 0.7.1 #15468

Closed
wants to merge 1 commit into from

Conversation

@mpscholten
Copy link
Contributor

commented May 14, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm

View changes

pkgs/tools/misc/fpp/default.nix Outdated
src = fetchFromGitHub {
owner = "facebook";
repo = "PathPicker";
rev = "refs/tags/${version}";

This comment has been minimized.

Copy link
@joachifm

joachifm May 15, 2016

Contributor

Does rev = version not work? It should.

This comment has been minimized.

Copy link
@mpscholten

mpscholten May 15, 2016

Author Contributor

Fixed

@joachifm

View changes

pkgs/tools/misc/fpp/default.nix Outdated
ln -s "$out/fpp" "$out/bin/fpp"
'';

installPhase = ''

This comment has been minimized.

Copy link
@joachifm

joachifm May 15, 2016

Contributor

Instead of a wrapper, I think it'd be much better to patch the script directly. Looking at the source, it sets PYTHONCMD="python" so that's probably what you want to patch.

This comment has been minimized.

Copy link
@joachifm

joachifm May 15, 2016

Contributor

Also, I think buildPhase really belongs in the installPhase; if the standard build phase is causing problems here, simply set dontBuild = true to disable it.

This comment has been minimized.

Copy link
@mpscholten

mpscholten May 15, 2016

Author Contributor

Both fixed 👍

Marc Scholten

@mpscholten mpscholten force-pushed the mpscholten:fpp branch to 74de7b1 May 15, 2016

@joachifm

This comment has been minimized.

Copy link
Contributor

commented May 15, 2016

Pushed a modified version to master. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.