Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpp: init at 0.7.1 #15468

Closed
wants to merge 1 commit into from
Closed

fpp: init at 0.7.1 #15468

wants to merge 1 commit into from

Conversation

@mpscholten
Copy link
Contributor

@mpscholten mpscholten commented May 14, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

src = fetchFromGitHub {
owner = "facebook";
repo = "PathPicker";
rev = "refs/tags/${version}";
Copy link
Contributor

@joachifm joachifm May 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does rev = version not work? It should.

Loading

Copy link
Contributor Author

@mpscholten mpscholten May 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Loading

@joachifm
Copy link
Contributor

@joachifm joachifm commented May 15, 2016

Pushed a modified version to master. Thank you.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants