Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift: 5.5.2 -> 5.5.3 #158898

Merged
merged 1 commit into from
Feb 18, 2022
Merged

swift: 5.5.2 -> 5.5.3 #158898

merged 1 commit into from
Feb 18, 2022

Conversation

dduan
Copy link
Contributor

@dduan dduan commented Feb 10, 2022

Motivation for this change

5.5.3 is a patch release specific for Linux and Windows. I build the Nix expression locally to verify all tests from the toolchain passed.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dduan
swift: 5.5.2 -> 5.5.3
1b854ec 
5.5.3 is a patch release specific for Linux and Windows. I build the Nix
  expression locally to verify all tests from the toolchain passed.
@dduan dduan requested a review from trepetti February 10, 2022 06:26
@ofborg ofborg bot requested a review from dtzWill February 10, 2022 06:39
@dduan
Copy link
Contributor Author

dduan commented Feb 13, 2022

@trepetti @dtzWill The bad news is apple dropped a new release almost at the same time we merged 5.5.2. The good news is that it's a patch release with minor changes. I'd appreciate a quick review if you had time.

trepetti
trepetti approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@trepetti trepetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

c0bw3b
c0bw3b approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 158898 run on x86_64-linux 1

1 package built:
  • swift

and I can run swiftc

@c0bw3b c0bw3b merged commit 0809eee into NixOS:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@trepetti trepetti trepetti approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dduan @c0bw3b @trepetti