for eclipse use older cairo. #167

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@MarcWeber
Contributor

With newer cairo Eclipse crashes after selecting a workspace

@MarcWeber
Contributor

strange - only _sdk_42 causes the problems. _37 is fine.

@shlevy shlevy commented on the diff Feb 22, 2013
pkgs/applications/editors/eclipse/default.nix
@@ -1,12 +1,23 @@
{ stdenv, fetchurl, patchelf, makeDesktopItem, makeWrapper
, freetype, fontconfig, libX11, libXext, libXrender, zlib
, glib, gtk, libXtst, jre
+, pkgs, applyGlobalOverrides
@shlevy
shlevy Feb 22, 2013 Member

Please don't pass pkgs around.

@MarcWeber
MarcWeber Feb 23, 2013 Contributor

Why not?

@shlevy
shlevy Mar 8, 2013 Member

Because it breaks abstraction. Now to have different versions of eclipse you have to import multiple times to change the packages it depends on, and it's not clear from the function signature what eclipse depends on.

@shlevy shlevy added a commit that referenced this pull request Mar 11, 2013
@shlevy shlevy eclipses: use older cairo
In #167, Marc Weber reported that eclipse crashes after selecting a
workspace with the current nixpkgs cairo. This has the same functional
change as #167, but IMO the implementation is cleaner.

Fixes #167

Signed-off-by: Shea Levy <shea@shealevy.com>
3e61084
@shlevy shlevy added a commit that closed this pull request Mar 11, 2013
@shlevy shlevy eclipses: use older cairo
In #167, Marc Weber reported that eclipse crashes after selecting a
workspace with the current nixpkgs cairo. This has the same functional
change as #167, but IMO the implementation is cleaner.

Fixes #167

Signed-off-by: Shea Levy <shea@shealevy.com>
3e61084
@shlevy shlevy closed this in 3e61084 Mar 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment