Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-full: Fix eval #167857

Merged
merged 1 commit into from
Apr 9, 2022
Merged

terraform-full: Fix eval #167857

merged 1 commit into from
Apr 9, 2022

Conversation

roberth
Copy link
Member

@roberth roberth commented Apr 8, 2022 •
edited
Loading

Description of changes

#166792 made the aliases work, which was unexpected for terraform-full.

Thanks to zowoq for reporting #166792 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@roberth
terraform-full: Fix eval
3c23838 
NixOS#166792 made the
aliases work, which was unexpected for terraform-full.

Thanks to zowoq for reporting
NixOS#166792 (comment)
@roberth roberth requested a review from zowoq as a code owner April 8, 2022 11:23
@zowoq zowoq requested a review from zimbatm April 8, 2022 11:27
@zimbatm zimbatm merged commit 375eaf2 into NixOS:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberth @zimbatm