-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/create_ap: add module #168510
nixos/create_ap: add module #168510
Conversation
|
|
|
so the module does not work at the moment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test the service so far, will try that next
|
Okay tested the service and it works now :) Ready to merge if it is okay for you |
|
if this is still a draft, please mark it as such |
|
Thank you for this explanation, I guess that makes sense. I added the changes and it looks fine for me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change I think I'm happy:)
|
I tested basic functionality and it seems to work. My phone is connecting (dhcp isn't working but i didn't configure it anyway) and i can ping it from my laptop. I might use this in the future 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Lassulus
|
This might be a stupid question, but what does this do that |
|
This script also uses hostapd as a dependency. I guess it is even simpler than using hostapd directly since it also setups dhcp and routing |
|
Looks good to me, thanks to everyone involved! |
Description of changes
Working on a module for the new package linux-wifi-hotspot. I would like to be able to create a wifi hotspot with this NixOS service like this:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes