Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradle: cleanup #169566

Merged
merged 1 commit into from
Sep 22, 2022
Merged

gradle: cleanup #169566

merged 1 commit into from
Sep 22, 2022

Conversation

lorenzleutgeb
Copy link
Member

Description of changes
  • Add some comments to better explain parameters
  • Choose more descriptive variable names
  • Promote supported platforms of Gradle Native Platform to be the default

@lorenzleutgeb
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@smancill
Copy link
Contributor

This is changing the platforms for Gradle 4 and 5 from platforms.unix to the defined list. Is that OK?

@SuperSandro2000
Copy link
Member

/marvin opt-in /status needs_reviewer

marvin no longer is a thing.

@SuperSandro2000 SuperSandro2000 changed the title gradle: Cleanup gradle: cleanup Sep 22, 2022
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 16bb7a8 into NixOS:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lorenzleutgeb @smancill @SuperSandro2000 @wamserma @Artturin