Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/appvm: init at unstable-2021-12-20 #173761

Merged
merged 1 commit into from
May 26, 2022
Merged

nixos/appvm: init at unstable-2021-12-20 #173761

merged 1 commit into from
May 26, 2022

Conversation

onny
Copy link
Contributor

@onny onny commented May 20, 2022

Description of changes

This PR packages the program appvm and a module to set the right user permissions. Using appvm you could seamlessly run applications inside a virtual machine.

Enable it:

services.virtualisation.appvm = {
  enable = true;
  user = "onny";
};

Run an application:

appvm start chromium
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@onny onny marked this pull request as draft May 20, 2022 12:22
@onny onny changed the title nixos/appvm: init at unstable-2021-12-20 [DRAFT] nixos/appvm: init at unstable-2021-12-20 May 20, 2022
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 20, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 20, 2022
@ofborg ofborg bot requested review from cab404, kalbasit and jollheef May 20, 2022 12:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels May 20, 2022
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels May 20, 2022
@onny onny force-pushed the appvm branch 3 times, most recently from fc972af to 8bf5854 Compare May 21, 2022 21:31
@onny onny marked this pull request as ready for review May 21, 2022 21:31
@onny onny changed the title [DRAFT] nixos/appvm: init at unstable-2021-12-20 nixos/appvm: init at unstable-2021-12-20 May 21, 2022
@onny onny force-pushed the appvm branch 3 times, most recently from 1a3b118 to 1d27516 Compare May 23, 2022 18:13
@onny onny requested a review from happysalada May 23, 2022 18:15
@onny onny force-pushed the appvm branch 2 times, most recently from e58beb7 to 2b769e1 Compare May 23, 2022 19:04
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 23, 2022
Co-authored-by: Mikhail Klementev <blame@dumpstack.io>
Co-authored-by: Cabia Rangris <me@cab404.ru>
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 24, 2022
@happysalada
Copy link
Contributor

Looks good, thank you!

@happysalada happysalada merged commit f81c763 into NixOS:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants