git: Update to 1.9.0 #1747

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@linquize
Contributor

linquize commented Feb 15, 2014

No description provided.

@bjornfor

This comment has been minimized.

Show comment
Hide comment
@bjornfor

bjornfor Feb 15, 2014

Contributor

Pushed to master.

Contributor

bjornfor commented Feb 15, 2014

Pushed to master.

@bjornfor bjornfor closed this Feb 15, 2014

@linquize linquize deleted the linquize:git-1.9.0 branch Feb 15, 2014

@vizanto

This comment has been minimized.

Show comment
Hide comment
@vizanto

vizanto Feb 25, 2014

Contributor
 /nix/store/amwxl4679nv99xpfznlhwzjpg62bh3wi-git-1.9.0/libexec/git-core/git-submodule: line 552: git reset: command not found
Contributor

vizanto commented Feb 25, 2014

 /nix/store/amwxl4679nv99xpfznlhwzjpg62bh3wi-git-1.9.0/libexec/git-core/git-submodule: line 552: git reset: command not found
@linquize

This comment has been minimized.

Show comment
Hide comment
@linquize

linquize Feb 25, 2014

Contributor

@vizanto
export PATH=/nix/store/amwxl4679nv99xpfznlhwzjpg62bh3wi-git-1.9.0:$PATH
git submodule foreach 'git reset --hard'
No problem for me.

Contributor

linquize commented Feb 25, 2014

@vizanto
export PATH=/nix/store/amwxl4679nv99xpfznlhwzjpg62bh3wi-git-1.9.0:$PATH
git submodule foreach 'git reset --hard'
No problem for me.

@vizanto

This comment has been minimized.

Show comment
Hide comment
@vizanto

vizanto Feb 25, 2014

Contributor

Adding the root of git nixpkg to PATH? That doesn't seem right.

Contributor

vizanto commented Feb 25, 2014

Adding the root of git nixpkg to PATH? That doesn't seem right.

@vizanto

This comment has been minimized.

Show comment
Hide comment
@vizanto

vizanto Feb 25, 2014

Contributor

Btw I just rolled back to 1.8.5.2 which has no problems. 5b41db9
Might be a bug in git itself?

Contributor

vizanto commented Feb 25, 2014

Btw I just rolled back to 1.8.5.2 which has no problems. 5b41db9
Might be a bug in git itself?

@linquize

This comment has been minimized.

Show comment
Hide comment
@linquize

linquize Feb 25, 2014

Contributor

I also tried
/nix/store/amwxl4679nv99xpfznlhwzjpg62bh3wi-git-1.9.0/bin/git submodule foreach '/nix/store/amwxl4679nv99xpfznlhwzjpg62bh3wi-git-1.9.0/bin/git reset --hard'
and it succeeded.

I also tried nix-env -i -f . -A git and then git submodule foreach 'git reset --hard'.
No problem.

Contributor

linquize commented Feb 25, 2014

I also tried
/nix/store/amwxl4679nv99xpfznlhwzjpg62bh3wi-git-1.9.0/bin/git submodule foreach '/nix/store/amwxl4679nv99xpfznlhwzjpg62bh3wi-git-1.9.0/bin/git reset --hard'
and it succeeded.

I also tried nix-env -i -f . -A git and then git submodule foreach 'git reset --hard'.
No problem.

@peti

This comment has been minimized.

Show comment
Hide comment
@peti

peti Feb 28, 2014

Member

Git 1.9.0 works just fine for me:

[simons@work:/tmp/mini-httpd]$ git --version
git version 1.9.0

[simons@work:/tmp/mini-httpd]$ git submodule foreach pwd
Entering 'libscheduler'
/tmp/mini-httpd/libscheduler
Member

peti commented Feb 28, 2014

Git 1.9.0 works just fine for me:

[simons@work:/tmp/mini-httpd]$ git --version
git version 1.9.0

[simons@work:/tmp/mini-httpd]$ git submodule foreach pwd
Entering 'libscheduler'
/tmp/mini-httpd/libscheduler
@vizanto

This comment has been minimized.

Show comment
Hide comment
@vizanto

vizanto Feb 28, 2014

Contributor

Odd. Git submodule command was run by Jenkins. Maybe it's a shell argument quoting difference, as they changed some of that in 1.9.0 in the submodule command.

This is the Jenkins log output with 1.9.0:

11:35:04 Resetting working tree
11:35:05 FATAL: Command "submodule foreach --recursive git reset --hard" returned status code 1:

Note the unquoted git reset --hard

No problems with 1.8.5.2

Contributor

vizanto commented Feb 28, 2014

Odd. Git submodule command was run by Jenkins. Maybe it's a shell argument quoting difference, as they changed some of that in 1.9.0 in the submodule command.

This is the Jenkins log output with 1.9.0:

11:35:04 Resetting working tree
11:35:05 FATAL: Command "submodule foreach --recursive git reset --hard" returned status code 1:

Note the unquoted git reset --hard

No problems with 1.8.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment