Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/snipe-it: init #180772

Merged
merged 1 commit into from Apr 26, 2023
Merged

Conversation

yayayayaka
Copy link
Member

@yayayayaka yayayayaka commented Jul 8, 2022

Description of changes

Introduces a NixOS test for the services.snipe-it module.

This PR depends on #180768 and #180770 being merged and is therefore marked as draft for now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1299

@yu-re-ka
Copy link
Contributor

Is this ready to be merged?

@yu-re-ka
Copy link
Contributor

@ofborg build nixosTests.snipe-it

@yu-re-ka yu-re-ka merged commit 5effdaa into NixOS:master Apr 26, 2023
19 of 21 checks passed
@yayayayaka
Copy link
Member Author

Is this ready to be merged?

It is. Thanks!

@yayayayaka yayayayaka deleted the snipe-it-nixos-test branch April 26, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants