setup-hooks/separate-debug-info.sh: don't inhibit strip hook

[trofi]

Before the change separate-debug-info.sh did the stripping itself.
This scheme has a few problems:

1. Stripping happens only on ELF files. *.a and *.o files are skipped.
   Derivations have to do it manually. Usually incorrectly
   as they don't run $RANLIB (true for glibc and musl).
2. Stripping happens on all paths. Ideally only stripDebugList paths
   should be considered.
3. Host strip is called on Target files.

This change offloads stripping logic to strip hook. This strips more
files for glibc and musl. Now we can remove most $STRIP calls
from individual derivations.

To avoid strip hook from stomping on results of separate-debug-info
hook we skip lib/debug directory from stripping.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[mweinelt]

@oxalica PTAL at the firefox common.nix change.

[risicle]

See #164520

[risicle]

Sorry let me expand on that - specifically https://github.com/NixOS/nixpkgs/pull/164520/files#r846774388.

It would be really good to handle .a files, because otherwise adding separateDebugInfo has the danger of being a bomb that leaves unstripped .a files in the regular output, massively bloating it.

[trofi]

Sorry let me expand on that - specifically https://github.com/NixOS/nixpkgs/pull/164520/files#r846774388.

It would be really good to handle .a files, because otherwise adding separateDebugInfo has the danger of being a bomb that leaves unstripped .a files in the regular output, massively bloating it.

Note that this PR drops dontStrip=1 from separateDebugInfo to enable automatic *.a (and *.o) file handling. This makes strip hook and separate-debug hooks both execute and do their job.

I started writing this change as I noticed that glibc is not fully stripping crt*.o and libm.a (and more in cross) files today. It should be fully handling it now.

[Mindavi]

Less stripping hacks sounds like a good idea to me. I looked through the PR and didn't see any obvious issues, but haven't tested a build myself.

[trofi]

I tested a few cross-compilers and native compilers: pkgsCross.mingw32.re2c, pkgsCross.ppc64.re2c, pkgsMusl.re2c, pkgsLLVM.re2c`. Did a light build of my whole system.

Let's give it a try. Worst case we can revert it.