New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mesa: 22.1.4 -> 22.1.5 #185699
mesa: 22.1.4 -> 22.1.5 #185699
Conversation
Are you sure that the darwin fixes have been included in 22.1.5? I haven't noticed them in the release notes. |
I somehow looked the wrong tag, reverting this... |
SRI: I like to simply paste the hash published on https homepages (example), but I don't really mind. |
Indeed, that's easier. Reverted... Instead of keeping the darwin friends outdated, I pulled the fix as a patch, seems fine right? Will ask a colleague to build it... |
@ofborg build mesa |
That most likely won't work, because the staging rebuilds are normally very large. (and ofborg tries to merge with newest version of the target branch) |
This comment was marked as outdated.
This comment was marked as outdated.
I only see a failure on |
@ofborg build mesa |
Successful builds in both aarch64 and x86_64 for darwin, against unstable:
I should have run the tests instead of package in ofborg... |
@vcunat what do you recommend me to deal with this? Keep the darwin patch (which builds, but I can't test), or revert and just push the bump? PS: Meanwhile, the "No channel PR" won't re-trigger in the right target. |
It sounds good to me this way. I think we've never tested mesa for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On linux-x86_64, mesa
builds for me. I cannot test for downstream breakage as it's staging. Merging this would be good to let hydra test it fully. Seems good to me for this purpose. If someone else (@vcunat maybe?) approves this, I'd be fine merging this.
Hydra doesn't test much relevant things, and |
Let's skip to 22.1.6? |
In another, less noised PR. |
Description of changes
Bump changes: https://docs.mesa3d.org/relnotes/22.1.5.html
Moved patches (that were already using SRI hashes), I've adopted what the wiki calls the preferred way.
Added the fix for https://gitlab.freedesktop.org/mesa/mesa/-/issues/6519 as a patch (for darwin only).
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes