Skip to content

python311Packages.cffi: patch failing test #198077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

voidus
Copy link
Contributor

@voidus voidus commented Oct 27, 2022

Steps To Reproduce

Steps to reproduce the behavior:
nix build nixpkgs#python311Packages.cffi

Build log

https://gist.github.com/voidus/90ea9dbfb3cbf08c026d866ca6acb8c8

Additional context

I debugged the issue and fixed the test, but upstream gitlab is down: https://foss.heptapod.net/pypy/cffi
Not sure how to best proceed, we could keep this open, I can submit it upstream in the next days and then remove the patch maybe?

Notify maintainers

@domenkozar @LnL7

Description of changes

Added a patch to fix the failing tests

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    • I didn't do that because a) no idea how to find the presumably huge number of affected packages and b) it doesn't build at all right now
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

> nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.00 MiB download, 0.00 MiB unpacked):
  /nix/store/q1drpnp5qifc38akiv4r169ll7cizisp-nix-info
copying path '/nix/store/q1drpnp5qifc38akiv4r169ll7cizisp-nix-info' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 6.0.2-arch1-1, Arch Linux, noversion, rolling`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.1`
 - channels(root): `""`
 - channels(voyd): `"home-manager, nixpkgs"`
 - channels(testie): `"nixpkgs"`
 - nixpkgs: `/home/voyd/.nix-defexpr/channels/nixpkgs`

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 27, 2022
@voidus
Copy link
Contributor Author

voidus commented Oct 27, 2022

We could also unconditionally include the patch, because the test suite already detects the python version, but I like that it's obvious from the nix code what the patch is supposed to affect

@voidus
Copy link
Contributor Author

voidus commented Oct 27, 2022

Pushed again with a better commit message

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 27, 2022
@voidus
Copy link
Contributor Author

voidus commented Oct 27, 2022

Upstream issue: https://foss.heptapod.net/pypy/cffi/-/issues/551

@voidus
Copy link
Contributor Author

voidus commented Oct 28, 2022

Upstream already has another patch for this, I'll update this to pull that one.

This seems like an upstream issue with the final release of python3.11.
Sadly, their gitlab is down right now, but I will pass the patch
upstream as soon as I can.
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on aarch64-darwin, aarch64-linux, and x86_64-linux, thanks for opening the PR!

@newAM newAM added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 11, 2022
@Mic92 Mic92 merged commit 80996a6 into NixOS:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants