Repository navigation
python311Packages.cffi: patch failing test - #198077
Merged
Merged
Conversation
Contributor
Author
|
We could also unconditionally include the patch, because the test suite already detects the python version, but I like that it's obvious from the nix code what the patch is supposed to affect |
Contributor
Author
|
Pushed again with a better commit message |
Contributor
Author
|
Upstream issue: https://foss.heptapod.net/pypy/cffi/-/issues/551 |
Contributor
Author
|
Upstream already has another patch for this, I'll update this to pull that one. |
This seems like an upstream issue with the final release of python3.11. Sadly, their gitlab is down right now, but I will pass the patch upstream as soon as I can.
newAM
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps To Reproduce
Steps to reproduce the behavior:
nix build nixpkgs#python311Packages.cffiBuild log
https://gist.github.com/voidus/90ea9dbfb3cbf08c026d866ca6acb8c8
Additional context
I debugged the issue and fixed the test, but upstream gitlab is down: https://foss.heptapod.net/pypy/cffi
Not sure how to best proceed, we could keep this open, I can submit it upstream in the next days and then remove the patch maybe?
Notify maintainers
@domenkozar @LnL7
Description of changes
Added a patch to fix the failing tests
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesMetadata
Please run
nix-shell -p nix-info --run "nix-info -m"and paste the result.