New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdata: allow execution without a config file (16.09) #19864

Merged
merged 1 commit into from Nov 2, 2016

Conversation

Projects
None yet
3 participants
@womfoo
Contributor

womfoo commented Oct 25, 2016

Motivation for this change

backport #19861 to stable

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Oct 25, 2016

@womfoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lethalman to be a potential reviewer.

mention-bot commented Oct 25, 2016

@womfoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lethalman to be a potential reviewer.

@NeQuissimus NeQuissimus merged commit d5b6594 into NixOS:release-16.09 Nov 2, 2016

@womfoo womfoo deleted the womfoo:fix/netdata-16.09 branch Apr 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment