Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam: fix crash at startup with open source radeon drivers #20269

Merged
merged 2 commits into from Nov 10, 2016

Conversation

@corngood
Copy link
Contributor

commented Nov 8, 2016

Motivation for this change

This is basically a port of this fix from OpenSUSE.

Steam ships statically linked with a version of libcrypto that conflics with the one dynamically loaded by radeonsi_dri.so.

This provides a compatible one (w/ engine disabled, cpuid fix) and links it into the steam runtime.

The error looks like:

steam.sh: line 713: 7842 Segmentation fault (core dumped) 
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot

This comment has been minimized.

Copy link

commented Nov 8, 2016

@corngood, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rasendubi, @globin and @abbradar to be potential reviewers.

@corngood corngood referenced this pull request Nov 8, 2016
@@ -8702,7 +8702,8 @@ in
})
openssl_1_0_1
openssl_1_0_2
openssl_1_1_0;
openssl_1_1_0
openssl_1_0_2-steam;

This comment has been minimized.

Copy link
@rasendubi

rasendubi Nov 9, 2016

Member

We can add openssl-steam = openssl_1_0_2-steam; above and use that name in the steam package.

This comment has been minimized.

Copy link
@corngood

corngood Nov 10, 2016

Author Contributor

Yeah, good call. Updated.

@corngood corngood force-pushed the corngood:steam-fix branch to a120bad Nov 10, 2016
@fpletz
fpletz approved these changes Nov 10, 2016
@rasendubi rasendubi merged commit 7a301ee into NixOS:master Nov 10, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@FRidh

This comment has been minimized.

Copy link
Member

commented Nov 25, 2016

This broke the game "Wargame: European Escalation" for me.

relocation error: /home/freddy/.local/share/Steam/steamapps/common/Wargame European Escalation/Wargame: symbol ENGINE_load_builtin_engines, version OPENSSL_1.0.0 not defined in file libcrypto.so.1.0.0 with link time reference
@corngood

This comment has been minimized.

Copy link
Contributor Author

commented Nov 25, 2016

@FRidh Could you open an issue for this and tag me on it?

It looks like ubuntu has a version-script.patch for openssl which adds these version symbols.

I can try to build openssl-steam with that patch, but I might need your help to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.