rename sound.enableMediaKeys to sound.mediaKeys.enable and add sound.mediaKeys.volumeStep#21538
Merged
Mic92 merged 4 commits intoNixOS:masterfrom Jan 1, 2017
dermetfan:media-keys
Merged
rename sound.enableMediaKeys to sound.mediaKeys.enable and add sound.mediaKeys.volumeStep#21538Mic92 merged 4 commits intoNixOS:masterfrom dermetfan:media-keys
Mic92 merged 4 commits intoNixOS:masterfrom
dermetfan:media-keys
Conversation
and add sound.mediaKeys.volumeStep
|
@dermetfan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oxij, @edolstra and @obadz to be potential reviewers. |
dermetfan
changed the title
danbst
suggested changes
Dec 31, 2016
danbst
reviewed
Dec 31, 2016
Member
|
cc @edolstra |
and add sound.mediaKeys.volumeStep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly different than what I proposed in #20020 (comment) but backwards compatible.
Motivation for this change
#20020, #17068
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)