mitmproxy: 0.17.1 -> 1.0.2 #21639

merged 14 commits into from Jan 5, 2017


None yet

3 participants

fpletz commented Jan 4, 2017 edited
Motivation for this change

mitmproxy was marked as broken and needed fixing and a version bump.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits
@fpletz fpletz requested a review from FRidh Jan 4, 2017

@fpletz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.


That's a lot of updates, thanks. Please fix tests or at least include the reason as a comment for disabling them. I suppose the test suites are run for all other packages with all main interpreter versions?

+ watchdog editorconfig
+ ];
+ doCheck = false;
FRidh Jan 4, 2017 Member

no tests? Please always include a comment with the reason why tests are disabled.

propagatedBuildInputs = with self; [ six ];
+ doCheck = !isPy3k;
FRidh Jan 4, 2017 Member

can you include a reason why

+ src = pkgs.fetchurl {
+ url = "mirror://pypi/s/sortedcontainers/${name}.tar.gz";
+ sha256 = "1sjh8lccbmvwna91mlhl5m3z4320p07h063b8x8br4p4cll49w0g";
+ };
doCheck = false;
FRidh Jan 4, 2017 Member

can you include the reason

- propagatedBuildInputs = with self; [ ruamel_base ruamel_ordereddict ];
+ doCheck = false;
FRidh Jan 4, 2017 Member


fpletz commented Jan 4, 2017

Added comments with explanations for disabling the tests. I don't have time to fix the tests and packaging new and bumping existing python packages was tedious enough for me.

As indicated above, I have not run nox-review, so no idea yet if the bumps break other packages. I want to wait for travis to maybe finish successfully.

fpletz added some commits Jan 4, 2017
@fpletz fpletz pythonPackages.blinker: 1.3 -> 1.4 31ac32a
@fpletz fpletz pythonPackages.construct: 2.5.2 -> 2.8.10 fa696a3
@fpletz fpletz pythonPackages.cssutils: 0.9.9 -> 1.0.1 da8023b
@fpletz fpletz pythonPackages.pyperclip: 1.5.11 -> 1.5.27 46fe0fe
@fpletz fpletz pythonPackages.urwid: 1.3.0 -> 1.3.1 838862c
@fpletz fpletz pythonPackages.brotlipy: init at 0.6.0 956a400
@fpletz fpletz pythonPackages.sortedcontainers: init at 1.5.7 f594ee1
@fpletz fpletz pythonPackages.hyperframe: init at 4.0.1 cde1874
@fpletz fpletz pythonPackages.h2: init at 2.5.1 e7ee026
@fpletz fpletz pythonPackages.editorconfig: init at 0.12.1 85d3e82
@fpletz fpletz pythonPackages.typing: init at e373c3f
@fpletz fpletz pythonPackages.hpack: 2.0.1 -> 2.3.0 8f146f9
@fpletz fpletz pythonPackages.ruamel_yaml: 0.10.13 -> 0.13.7 7172561
@fpletz fpletz mitmproxy: 0.17.1 -> 1.0.2, move to all-packages.nix e94bfe5
fpletz commented Jan 5, 2017

Okay, so all reverse dependencies build for me with nox-review pr that were not broken before, so we're ready to merge. Also rebased against current master.

@FRidh FRidh merged commit 5136500 into NixOS:master Jan 5, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
@fpletz fpletz deleted the mayflower:pkg/mitmproxy branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment