godot: init at 2.1.1-stable #21689

Merged
merged 1 commit into from Jan 6, 2017

Projects

None yet

3 participants

@rzetterberg
Contributor

Adds the godot engine at the latest stable version.

This package builds the engine and the editor.

Since this is a fairly large C++ project I have added enableParallelBuilding = true; to speed up the build.

Using nix.buildCores = 4; on my computer that has a i5 760 the whole build took:

/nix/store/l0si3mbcacrhq9hz922qw2f8c9cr0y5g-godot-2.1.1-stable

real    7m41.175s
user    0m0.323s
sys     0m0.084s

Here's a short screencast of me opening the binary inside the result/bin dir after running nix-build:

godot

In the screencast I open the example project Minesweeper that I downloaded via the interface earlier. I then run the project and fail at sweeping all the mines.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS unstable (17.03pre96677.7926e75) x86_64
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
pkgs/development/tools/godot/default.nix
+ src = fetchFromGitHub {
+ owner = "godotengine";
+ repo = "godot";
+ rev = "3e2247ca5301ffe7a45dbda473336636540b8fa8";
@FRidh
FRidh Jan 6, 2017 edited Member

A tag is a rev as well so you can put rev = version here

@rzetterberg rzetterberg godot: init at 2.1.1-stable
Adds the [godot engine](https://godotengine.org/) at the latest stable
version.

Produced binary contains the tools and the engine itself.
4799971
@rzetterberg
Contributor

Thanks for the review, @FRidh

Here's what I did:

  • Add rev = version;
  • Rebuild the package using nix-build
  • Start the executable
  • Squash the commits and push to GitHub

2017-01-06-121224_1920x1200_scrot

@FRidh FRidh merged commit 39bb4fe into NixOS:master Jan 6, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@sunnystormy
sunnystormy commented Jan 7, 2017 edited

So glad somebody added this! Was about to open a ticket for getting this into Nixpkgs. 👍
---ADDENDUM---

Though the bigger question is, how would you run binaries made with the engine if NixOS doesn't allow you to do so? : /

Found it:

https://nixos.org/wiki/How_to_package_closed-source_software

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment