add alacritty #21801

Open
wants to merge 1 commit into
from

Projects

None yet

7 participants

@exi
Contributor
exi commented Jan 11, 2017
Motivation for this change

Add alacritty.

This package will only build once #21800 is merged

@exi
Contributor
exi commented Jan 11, 2017

@globin some love?

@globin globin self-assigned this Jan 11, 2017
+with rustPlatform;
+
+buildRustPackage rec {
+ name = "alacritty-${version}";
@Mic92
Mic92 Jan 11, 2017 Contributor

usually we have the following scheme when packaging packages without releases:

  name = "alacritty-unstable-<year>-<month>-<day>";
@exi
exi Jan 11, 2017 Contributor

fixed

+ cmake gcc pkgconfig freetype expat gperf
+ libX11 libXcursor libXxf86vm libXi
+ ];
+ buildInputs = [ ];
@Mic92
Mic92 Jan 11, 2017 Contributor

that could be dropped then.

@exi
exi Jan 11, 2017 Contributor

fixed

@gebner
Member
gebner commented Jan 11, 2017

Should we make hydra build this package? Right now we don't build rustNightly (or rustBeta), see #18111. cc @the-kenny

@exi
Contributor
exi commented Jan 11, 2017

@gebner @the-kenny #21804
Did not see the original discussion so i tried to introduce it again :)

@jb55
jb55 approved these changes Jan 11, 2017 View changes
@puffnfresh
Contributor

I was unable to build locally due to the Rust compiler stopping compilation with:

udp_clone_smoke has been running for over 60 seconds

But was able to build by overriding it with rustPlatform = (makeRustPlatform rustNightlyBin); - tried it out, it runs well!

@exi
Contributor
exi commented Jan 12, 2017

@puffnfresh i suspect that this happens because this branch is not rebased onto the latest master.
I just rebased and force pushed it and will try the build again myself.

@exi
Contributor
exi commented Jan 12, 2017

@puffnfresh just tried it with this branch on top of the current master and rust beta, rust nightly and alacritty build without issues

@jb55
Contributor
jb55 commented Jan 12, 2017

I can't seem to build either, I'm getting this: https://gist.github.com/jb55/7c438c1ecbb6ee34551aeb771e4841fe

@exi
Contributor
exi commented Jan 12, 2017

@jb55 you are not building from the right branch, the nightly version this is trying to build is way too old.
did you forget to "git pull" your master or something?

@jb55
Contributor
jb55 commented Jan 12, 2017

oops looks like my nixpkgs was dirty and had stuff in staging area. retrying now

@jb55
Contributor
jb55 commented Jan 12, 2017

works great 👍

@puffnfresh
Contributor

I'm getting the same UDP test problems so it must be something to do with my system.

@Mic92
Contributor
Mic92 commented Jan 16, 2017

@puffnfresh what operating system do you use? I had problems with failing udp tests on debian in a nix-user-chroot, but not on nixos.

@puffnfresh
Contributor

@Mic92 I use NixOS

@exi
Contributor
exi commented Jan 17, 2017

@puffnfresh @Mic92 could you check out the latest master and try again? I am wondering if this was an issue with the parallel/codegen PR that has been reverted 3 days ago

@puffnfresh
Contributor

I merged master into this branch and tried to build but I got the hang again:

test net::udp::tests::udp_clone_smoke has been running for over 60 seconds

@exi
Contributor
exi commented Jan 20, 2017 edited

@puffnfresh this seems like a bug that might be worth raising as a separate issue.
Could you maybe create a new issue with the build log? I think this should be a bug for rustc or rustBeta or rustNightly, depending on which build is failing

@Mic92
Contributor
Mic92 commented Jan 21, 2017

sandbox build failed because a dependency was attempt to download from git.

warning: custom registry support via the `registry.index` configuration is being removed, thisfunctionality will not work in the future
    Updating git repository `https://github.com/jwilm/glutin`
error: failed to load source for a dependency on `glutin`
@the-kenny
Contributor
the-kenny commented Jan 22, 2017 edited

@Mic92 this happens because alacritty uses a git-dependency of glutin. Not supported (yet?) on our build infrastructure. I think this error is caused by cargo not downloading git repositories in a non-deterministic way.

One would need to pin that revision and provide a separate fetchgit to download it. Alternative would be fixing cargo to use git archive or something instead of just cloning the repo.

To others: Note that the build might work on your machine if you have either a) disabled the sandbox or b) generated the hash for dependencies recently in which case it will fail again at some point

@Mic92
Contributor
Mic92 commented Jan 22, 2017 edited

@the-kenny actually buildRustPackage supports git and the package is also pinned to a revision, but it seems that cargo tries to update the pre-fetched git repository. I hope I can fix this with this behavior of cargo with this commit: #22021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment