Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdata module: add automatic claim #228479

Merged
merged 3 commits into from Jun 16, 2023
Merged

netdata module: add automatic claim #228479

merged 3 commits into from Jun 16, 2023

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Apr 27, 2023

Description of changes

Allow machines to auto-register themselves by passing the claim token.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zimbatm
netdata module: add automatic claim
f4d5a76 
Allow machines to auto-register themselves by passing the claim token.
@zimbatm zimbatm requested a review from misuzu April 27, 2023 08:33
misuzu
misuzu approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. It shouldn't break anything for existing users, didn't test though since I'm not using netdata anymore

RaitoBezarius
RaitoBezarius approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimbatm
Copy link
Member Author

zimbatm commented May 5, 2023

I noticed the machine UUID doesn't get auto-generated for some reason, so I need to add a fix

zimbatm and others added 2 commits May 5, 2023 18:41
@zimbatm @RaitoBezarius
Update nixos/modules/services/monitoring/netdata.nix
14793fa 
Co-authored-by: Ryan Lahfa <masterancpp@gmail.com>
@zimbatm @RaitoBezarius
Update nixos/modules/services/monitoring/netdata.nix
db8b28d 
Co-authored-by: Ryan Lahfa <masterancpp@gmail.com>
@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 228479 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

@RaitoBezarius
Copy link
Member

Please rebase your commits :)

@RaitoBezarius RaitoBezarius merged commit afc6f0d into NixOS:master Jun 16, 2023
19 checks passed
@RaitoBezarius
Copy link
Member

Okay, it's time to implement ofborg status checks for GitHub applied commits. :<

@zimbatm zimbatm deleted the netdata-auto-claim branch June 16, 2023 10:51
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Jun 16, 2023
@eadwu
Revert "Merge pull request NixOS#228479 from zimbatm/netdata-auto-claim"
ccbbcee 
This reverts commit afc6f0d, reversing
changes made to b5a987d.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Jun 17, 2023
@eadwu
Revert "Merge pull request NixOS#228479 from zimbatm/netdata-auto-claim"
d21e194 
This reverts commit afc6f0d, reversing
changes made to b5a987d.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Jun 17, 2023
@eadwu
Revert "Merge pull request NixOS#228479 from zimbatm/netdata-auto-claim"
1017a08 
This reverts commit afc6f0d, reversing
changes made to b5a987d.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Jun 17, 2023
@eadwu
Revert "Merge pull request NixOS#228479 from zimbatm/netdata-auto-claim"
8441441 
This reverts commit afc6f0d, reversing
changes made to b5a987d.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Jun 18, 2023
@eadwu
Revert "Merge pull request NixOS#228479 from zimbatm/netdata-auto-claim"
f8cf70b 
This reverts commit afc6f0d, reversing
changes made to b5a987d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu misuzu approved these changes

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12.approvals: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zimbatm @RaitoBezarius @misuzu @mweinelt @figsoda