Skip to content

Conversation

@apfelkuchen6
Copy link
Contributor

@apfelkuchen6 apfelkuchen6 commented May 20, 2023

This fixes a bug that allowed any document compiled with LuaTeX to execute arbitrary shell commands, even with shell escape disabled. This issue is CVE-2023-32700.

See https://tug.org/~mseven/luatex.html for more details.

The fix applied does not fix the socket vulnerability descibed on that page (CVE-2023-32668), which allows any code to create network requests. Patching this requires breaking compatibility. In particular the ConTeXt version shipped with texlive-2022 does not work with luatex-1.17. I'm not sure what we want to do about that. Debian also only patches CVE-2023-32700.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label May 20, 2023
@apfelkuchen6 apfelkuchen6 requested review from veprbl and xworld21 May 20, 2023 11:19
@apfelkuchen6 apfelkuchen6 added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-22.11 labels May 20, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 20, 2023
This fixes a bug that allowed any document compiled with LuaTeX to execute
arbitrary shell commands, even with shell escape disabled.

See https://tug.org/~mseven/luatex.html for more details.
@apfelkuchen6 apfelkuchen6 force-pushed the luatex-fix-shell-escape branch from b42c887 to 23cf0d4 Compare May 20, 2023 17:14
@risicle
Copy link
Contributor

risicle commented May 20, 2023

Definitely appears to address the test case provided in https://tug.org/~mseven/luatex.html on x86_64 linux and macos 10.15 for texlive.combined.scheme-full

@github-actions
Copy link
Contributor

Successfully created backport PR for release-22.11:

@apfelkuchen6 apfelkuchen6 deleted the luatex-fix-shell-escape branch May 20, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants