dune_3: 3.7.1 -> 3.8.1 #233595
Merged
dune_3: 3.7.1 -> 3.8.1 #233595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #233585? |
|
@vbgl I suppose so, I missed it since we just released 2 hours ago. I'll include any relevant fixes to other packages here so they can be cherry-picked then. |
|
Result of 4 packages failed to build:
941 packages built:
|
|
@ofborg build spark2014 |
|
|
im aware of the issues with the coq packages. Ill write some patches to the dune files to fix them. They are currently stemming from a bug in 3.8 with how COQPATHis handled. This is only specific to how we package coq in nix. |
|
This should probably expose |
|
The issue with COQPATH is reported in dune and will likely have a fix for 3.8.1: ocaml/dune#7790 |
Alizter
force-pushed
the
ps/branch/dune_3__3_7_1____3_8_0
branch
from
804e01d
to
756014a
Compare
|
I'm testing what will be in 3.8.1 which appears to fix the issues with the Coq builds. We (the dune team) will cut a new point release very soon, so I think it will be best to wait for that rather than marking these Coq packages as broken or setting up some complicated patches or workarounds. |
|
Result of 1 package marked as broken and skipped:
944 packages built:
|
Alizter
force-pushed
the
ps/branch/dune_3__3_7_1____3_8_0
branch
from
756014a
to
5cc4312
Compare
|
ive just pushed 3.8.1 which was released today. I need to update the commit message, but I am currently travelling and unable to. |
|
@anmonteiro can you push the darwin changes that are needed? |
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
ps/branch/dune_3__3_7_1____3_8_0
branch
from
5cc4312
to
eaa13f3
Compare
|
Result of 1 package marked as broken and skipped:
1 package failed to build:
944 packages built:
|
wegank
reviewed
Jun 7, 2023
Co-authored-by: Weijia Wang <9713184+wegank@users.noreply.github.com>
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changelog: https://github.com/ocaml/dune/releases/tag/3.8.0
https://github.com/ocaml/dune/releases/tag/3.8.1
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)