New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mdformat plugins #241266
Add mdformat plugins #241266
Conversation
|
not sure why I am reviewer? lgtm, similar to my PR from before #234916 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you use buildInputs rather than propagatedBuildInputs? See #287074.
Why are the commit messages not prefixed with python311Packages.?
This should be fixed or the commits reverted asap.
|
I'm fixing this mess in #287103. This PR should never have been merged! |
At the time, I was learning how to package Python apps properly. So basically mistakes on my part.
I was not aware, again, at that time. Newer packages I have contributed related to Python has now that format.
Thank you for your work and for fixing the issues and improving the |
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Previous related PRs: