Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdformat plugins #241266

Merged
merged 12 commits into from Jul 3, 2023
Merged

Add mdformat plugins #241266

merged 12 commits into from Jul 3, 2023

Conversation

aldoborrero
Copy link
Contributor

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Previous related PRs:

@polarmutex
Copy link
Contributor

not sure why I am reviewer? lgtm, similar to my PR from before #234916

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you use buildInputs rather than propagatedBuildInputs? See #287074.
Why are the commit messages not prefixed with python311Packages.?
This should be fixed or the commits reverted asap.

@dotlambda
Copy link
Member

dotlambda commented Feb 8, 2024

I'm fixing this mess in #287103. This PR should never have been merged!

@aldoborrero
Copy link
Contributor Author

aldoborrero commented Feb 9, 2024

Any reason you use buildInputs rather than propagatedBuildInputs? See #287074.

At the time, I was learning how to package Python apps properly. So basically mistakes on my part.

Why are the commit messages not prefixed with python311Packages.?

I was not aware, again, at that time. Newer packages I have contributed related to Python has now that format.

I'm fixing this mess in #287103. This PR should never have been merged!

Thank you for your work and for fixing the issues and improving the withPlugins code. Even if you consider this PR a mess, it brought to the table useful tooling (albeit with errors, I do agree).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants