znapzend service: fix reload#25009
Merged
7c6f434c merged 2 commits intoNixOS:masterfrom May 1, 2017
dermetfan:fix-znapzend-service
Merged
znapzend service: fix reload#250097c6f434c merged 2 commits intoNixOS:masterfrom dermetfan:fix-znapzend-service
7c6f434c merged 2 commits intoNixOS:masterfrom
dermetfan:fix-znapzend-service
Conversation
Mic92
reviewed
Apr 19, 2017
| ${pkgs.coreutils}/bin/kill -HUP $MAINPID | ||
| ''; | ||
| serviceConfig = { | ||
| ExecStart = "${pkgs.znapzend}/bin/znapzend"; |
Member
There was a problem hiding this comment.
The script attribute was unnecessary here.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#24438
In addition to
/bin/killnot being found, the script forked so that$MAINPIDbecame the PID of the shell instead of the znapzend process. When SIGHUP was sent to the shelI, it sent SIGTERM to znapzend.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)