Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Init Solo5 #25041

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@dmjio
Copy link
Contributor

commented Apr 19, 2017

Motivation for this change

Add Solo5 to nixpkgs.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dmjio dmjio changed the title Init Solo5 DON'T MERGE YET - Init Solo5 Apr 19, 2017

@dmjio dmjio changed the title DON'T MERGE YET - Init Solo5 WIP - Init Solo5 Apr 19, 2017

@7c6f434c

This comment has been minimized.

Copy link
Member

commented May 1, 2017

Could you please force-push a version with meta added?

name = "solo5";
hardeningDisable = [ "stackprotector" ];
installPhase = ''
PREFIX=$out

This comment has been minimized.

Copy link
@JohnAZoidberg

JohnAZoidberg Apr 27, 2019

Contributor

Why not use $out directly?
And why not use the Makefile's install?

@aanderse

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@dmjio do you have intention to continue this PR?

@dmjio dmjio closed this May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.