Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlxmirror: init at 2023-07-05 #250992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatthewCroughan
Copy link
Contributor

Description of changes

Initializes https://github.com/galister/wlxmirror which allows you to share the framebuffer of one wayland compositor in another

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@MatthewCroughan
Copy link
Contributor Author

I accomplished https://twitter.com/MatthewCroughan/status/1694426449195778428 with wlxmirror today, as evidence that it works as intended.


buildDotnetModule {
pname = "wlxmirror";
version = "2023-07-05";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "2023-07-05";
version = "unstable-2023-07-05";

or better use the new format based on the latest tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 you can't do that in buildDotnetModule, it causes it to fail, saying it's an invalid version

> /nix/store/nldnia8a13619bmyrb3y8npcyrzxzh42-dotnet-sdk-6.0.412/sdk/6.0.412/NuGet.targets(132,5): error : 'unstable-2023-07-05' is not a valid version string. (Parameter 'value') [/build/source/WlxMirror.sln]

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants