Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-utils: include man pages in the output of vim_customizable.customize, add option to include gvim wrapper #26111

Closed
wants to merge 1 commit into from

Conversation

@therealpxc
Copy link
Contributor

therealpxc commented May 26, 2017

Motivation for this change

fixes #24691

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented May 26, 2017

@therealpxc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @edanaher and @nicknovitski to be potential reviewers.

@edanaher

This comment has been minimized.

Copy link
Contributor

edanaher commented May 26, 2017

Looks reasonable to me; my only question is whether there should be a separate flag for giving the gvim wrapper its own name (rather than g${name}). But I can definitely understand wanting to leave that out for now, especially given that previously gvim was completely unavailable, and apparently there weren't any complaints about that...

@nicknovitski

This comment has been minimized.

Copy link
Contributor

nicknovitski commented May 26, 2017

I have no objections, this clearly improves things.

@LnL7 LnL7 added the 6.topic: vim label May 26, 2017
@therealpxc

This comment has been minimized.

Copy link
Contributor Author

therealpxc commented Jun 11, 2017

What if we also want to wrap vimtutor and other ${vim}/bin outputs? Does anyone have a proposition for a more general solution? Then we could address the configurability issue for gvim's name in the same stroke.

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Jun 11, 2017

Do you want to change other things in this pull request or make it a new pull request?

@matix2267 matix2267 mentioned this pull request Feb 24, 2019
4 of 10 tasks complete
@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Feb 25, 2019

Superseded by #56277, closing

@xeji xeji closed this Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.