Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcrcon: init at 0.0.5 #26215

Merged
merged 1 commit into from
May 30, 2017
Merged

mcrcon: init at 0.0.5 #26215

merged 1 commit into from
May 30, 2017

Conversation

dermetfan
Copy link
Member

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@dermetfan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @vcunat to be potential reviewers.

buildInputs = [ gcc ];

buildPhase = ''
gcc mcrcon.c -o mcrcon
Copy link
Member

@Mic92 Mic92 May 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$CC mcrcon.c -o mcrcon

might be more portable.


installPhase = ''
mkdir -p $out/bin
install -m 755 mcrcon $out/bin
Copy link
Member

@Mic92 Mic92 May 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installPhase = ''
  install -D -m755 mcrcon $out/bin/mcron
'';

sha256 = "1pwr1cjldjy8bxqpp7w03nvdpw8l4vqfnk6w6b3mf0qpap1k700z";
};

buildInputs = [ gcc ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure there is a hard dependency on gcc? If not you can just remove this line and use the command as shown above.

install -m 755 mcrcon $out/bin
'';

phases = "unpackPhase buildPhase installPhase fixupPhase";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all default phases. You can remove this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I hoped excluding some could speed up the build. Not a good practice?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dermetfan disabling problematic phases as necessary is more robust, generally.

@FRidh FRidh merged commit ccafbac into NixOS:master May 30, 2017
@dermetfan dermetfan deleted the mcrcon branch May 30, 2017 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants