browserpass: 2017-04-11 -> 1.0.5 #26541
Conversation
|
@dermetfan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pajowu to be a potential reviewer. |
|
Looks good to me but I've never used this so cannot say for certain ☺ CC @pajowu |
| ''; | ||
| }; | ||
| }; | ||
| programs.browserpass.enable = mkEnableOption "the NativeMessaging configuration for installed browsers."; |
There was a problem hiding this comment.
This would only work for chrome, right? Maybe mention this in the description.
There was a problem hiding this comment.
Yes, I could not get it to work with firefox. b4caf7a looks like it tried to add firefox support but from what I can see it does not affect the NixOS module.
There was a problem hiding this comment.
@dermetfan unfortunately it doesn't work because Firefox expects the path to the native messaging hosts to be /usr/{lib,lib64,share}/mozilla/native-messaging-hosts/<name>.json, see https://wiki.mozilla.org/WebExtensions/Native_Messaging
As far as I can tell the only solution is to patch Firefox to use an environment variable (like MOZ_PLUGIN_PATH) or to wrap it in buildFHSUserEnv.
There was a problem hiding this comment.
If I understand correctly that would be implemented in the firefox wrapper. Let's merge this first and open another issue if desired since we didn't have firefox support before this PR.
|
Any opposition to a merge of this PR as it is now? |
|
ping @fpletz |
Motivation for this change
See nix-community/home-manager#16 (comment).
This also updates the NixOS module.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)