meld: avoid -dev paths in runtime closure#265454
Merged
Atemu merged 1 commit intoNixOS:masterfrom Nov 8, 2023
Merged
Conversation
FliegendeWurst
added
the
6.topic: closure size
ofborg
bot
added
10.rebuild-darwin: 1-10
jtojnar
reviewed
Nov 4, 2023
Comment on lines
48
to
51
Member
There was a problem hiding this comment.
It appears to work without this?
Contributor
Author
There was a problem hiding this comment.
Removed buildInputs addition and left only pythonPath.
Use `pythonPath` instead of `propagatedBuildInputs`.
Closure before the change:
$ nix path-info -rsSh $(nix-build '<nixpkgs>' -A meld) | unnix | nl | tail -n1
185 /<<NIX>>/meld-3.22.0 5.2M 512.7M
After the change:
$ nix path-info -rsSh $(nix-build -A meld) | unnix | nl | tail -n1
155 /<<NIX>>/meld-3.22.0 5.2M 480.8M
This way we avoid 30 depends and 32MB of closure. Those were the
following packages:
/<<NIX>>/brotli-1.1.0
/<<NIX>>/brotli-1.1.0-dev
/<<NIX>>/bzip2-1.0.8-dev
/<<NIX>>/cairo-1.16.0-dev
/<<NIX>>/expat-2.5.0-dev
/<<NIX>>/fontconfig-2.14.2-bin
/<<NIX>>/fontconfig-2.14.2-dev
/<<NIX>>/freetype-2.13.2-dev
/<<NIX>>/gettext-0.21.1
/<<NIX>>/glib-2.76.4-bin
/<<NIX>>/glib-2.76.4-dev
/<<NIX>>/glibc-2.38-23-bin
/<<NIX>>/glibc-2.38-23-dev
/<<NIX>>/glibc-iconv-2.38
/<<NIX>>/libelf-0.8.13
/<<NIX>>/libffi-3.4.4-dev
/<<NIX>>/libGL-1.6.0-dev
/<<NIX>>/libglvnd-1.6.0-dev
/<<NIX>>/libpng-apng-1.6.40-dev
/<<NIX>>/libX11-1.8.7-dev
/<<NIX>>/libXau-1.0.11-dev
/<<NIX>>/libxcb-1.16-dev
/<<NIX>>/libXext-1.3.5-dev
/<<NIX>>/libXrender-0.9.11-dev
/<<NIX>>/linux-headers-6.5
/<<NIX>>/python3.11-pygobject-3.44.1-dev
/<<NIX>>/xcb-util-0.4.1
/<<NIX>>/xcb-util-0.4.1-dev
/<<NIX>>/xorgproto-2023.2
/<<NIX>>/zlib-1.3-dev
trofi
force-pushed
the
meld-leaner-closure
branch
from
238a91a to
51a383c
Compare
jtojnar
approved these changes
Nov 4, 2023
delroth
added
the
12.approvals: 1
mimame
approved these changes
Nov 4, 2023
delroth
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
pythonPathinstead ofpropagatedBuildInputs.Closure before the change:
After the change:
This way we avoid 30 depends and 32MB of closure. Those were the following packages:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)