Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poco: fix static build #270781

Merged
merged 1 commit into from Nov 29, 2023
Merged

poco: fix static build #270781

merged 1 commit into from Nov 29, 2023

Conversation

emilytrau
Copy link
Member

Description of changes

Fixes #256077 @peacememories

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 馃憤 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from tomodachi94 November 29, 2023 04:31
@emilytrau emilytrau added the backport release-23.11 Backport PR automatically label Nov 29, 2023
tomodachi94
tomodachi94 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a smaller patch than I expected 馃槣

Lgtm, thanks for fixing this!

@emilytrau emilytrau merged commit d954289 into NixOS:master Nov 29, 2023
24 of 25 checks passed
@emilytrau emilytrau deleted the poco-musl branch November 29, 2023 05:48
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Nov 29, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomodachi94 tomodachi94 tomodachi94 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-23.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: pkgsStatic.poco
2 participants
@emilytrau @tomodachi94