Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

edb: 1.3.0 -> 1.4.0 #284625

Merged
merged 1 commit into from Jan 30, 2024
Merged

edb: 1.3.0 -> 1.4.0 #284625

merged 1 commit into from Jan 30, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 28, 2024

Among other things fixes build failure against gcc-13: https://hydra.nixos.org/build/247561087

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Among other things fixes build failure against `gcc-13`:
https://hydra.nixos.org/build/247561087
@trofi
Copy link
Contributor Author

trofi commented Jan 28, 2024

Result of nixpkgs-review pr 284625 run on x86_64-linux 1

1 package built:
  • edb

@marsam marsam merged commit 67f04d2 into NixOS:master Jan 30, 2024
34 checks passed
@trofi trofi deleted the edb-update branch January 31, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants