Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armagetronad.*: 0.2.9.1.1 -> 0.2.9.2.3 #284626

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jan 28, 2024

Description of changes

Add meta.mainProgram, bump Git SHAs for unstable, and make sure that buildInputs is minimal for dedicated servers. Bump version to 0.2.9.2.3 due to upstream updates.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@numinit numinit force-pushed the armagetronad-unstable-updates branch 2 times, most recently from 3c173ce to 7f7379c Compare February 12, 2024 07:44
@numinit numinit force-pushed the armagetronad-unstable-updates branch from 7f7379c to 3391365 Compare February 26, 2024 04:07
@numinit numinit changed the title armagetronad."0.4" + armagetronad."0.2.8-sty+ct+ap": update armagetronad.*: don't compile dedicated servers with graphical dependencies (SDL, opengl, etc) Feb 26, 2024
@numinit numinit self-assigned this Mar 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3563

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1519

@numinit
Copy link
Contributor Author

numinit commented Mar 13, 2024

Should be ready.

@numinit numinit force-pushed the armagetronad-unstable-updates branch from 855f37f to 24c913d Compare March 21, 2024 02:47
@numinit numinit changed the title armagetronad.*: don't compile dedicated servers with graphical dependencies (SDL, opengl, etc) armagetronad.*: 0.2.9.1.1 -> 0.2.9.2.3 Mar 21, 2024
@numinit
Copy link
Contributor Author

numinit commented Mar 21, 2024

@SuperSandro2000 I added a commit bumping version due to upstream updates and fixing the integration tests. A lot of them are failing to build treewide with:

error:
       … from call site

         at «none»:0: (source not available)

       error: function 'anonymous lambda' called without required argument 'system'

       at /home/numinit/projects/nix/nixpkgs/nixos/tests/make-test-python.nix:1:4:

            1| f: {
             |    ^
            2|   system,

@SuperSandro2000
Copy link
Member

Not sure what wrong there, how are you calling the tests. IIRC they should be run like nix-build -A nixosTests.vaultwarden

@SuperSandro2000
Copy link
Member

Should be ready.

Does this still apply? Otherwise looks alright to me and we can merge it.

@numinit
Copy link
Contributor Author

numinit commented Mar 21, 2024

@SuperSandro2000 yeah, turns out I was doing nix-build nixos/tests/armagetronad.nix. Good from my end, all ready.

@SuperSandro2000 SuperSandro2000 merged commit 60f419e into NixOS:master Mar 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants