-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
armagetronad.*: 0.2.9.1.1 -> 0.2.9.2.3 #284626
armagetronad.*: 0.2.9.1.1 -> 0.2.9.2.3 #284626
Conversation
3c173ce
to
7f7379c
Compare
7f7379c
to
3391365
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3563 |
3391365
to
855f37f
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1519 |
Should be ready. |
855f37f
to
24c913d
Compare
@SuperSandro2000 I added a commit bumping version due to upstream updates and fixing the integration tests. A lot of them are failing to build treewide with:
|
Not sure what wrong there, how are you calling the tests. IIRC they should be run like |
Does this still apply? Otherwise looks alright to me and we can merge it. |
@SuperSandro2000 yeah, turns out I was doing |
Description of changes
Add
meta.mainProgram
, bump Git SHAs for unstable, and make sure that buildInputs is minimal for dedicated servers. Bump version to 0.2.9.2.3 due to upstream updates.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.