pcre2: backport jit auto-detection#300565
Merged
marsam merged 1 commit intoNixOS:stagingfrom Apr 6, 2024
Merged
Conversation
Without the change `pcre2` build without `jit` support. This happens
because --wit-jit=auto was broken in this release. THe change backports
upstream fix.
Before the change ./configure log:
pcre2> Enable JIT compiling support ....... : no
After the change:
pcre2> Enable JIT compiling support ....... : yes
I initially observed the failures on `rizin` as a spam of failures to
JIT a trivial regex:
$ rizin
ERROR: Regex compilation for '\s+' failed at 0: bad JIT option
ERROR: Regex compilation for '\s+' failed at 0: bad JIT option
...
ERROR: Regex compilation for '\s+' failed at 0: bad JIT option
-- Check your IO plugins with 'rizin -L'
[0x00000000]>
marsam
approved these changes
Apr 1, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change
pcre2build withoutjitsupport. This happens because --wit-jit=auto was broken in this release. THe change backports upstream fix.Before the change ./configure log:
After the change:
I initially observed the failures on
rizinas a spam of failures to JIT a trivial regex:Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.