Skip to content

bump elm node packages#304198

Closed
domenkozar wants to merge 1 commit into
NixOS:masterfrom
domenkozar:bump-elm-node-packages
Closed

bump elm node packages#304198
domenkozar wants to merge 1 commit into
NixOS:masterfrom
domenkozar:bump-elm-node-packages

Conversation

@domenkozar

Copy link
Copy Markdown
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg Bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 15, 2024
@turboMaCk

Copy link
Copy Markdown
Member
2 packages marked as broken and skipped:
elmPackages.elm-coverage elmPackages.elm-verify-examples

2 packages failed to build:
elmPackages.elm-land elmPackages.elm-pages

The marked as broken are not a new thing and were discussed in some past PR.

The failure in elm-land and elm-pages might be a blocker though. cc @zupo @jali-clarke

@turboMaCk turboMaCk self-requested a review April 15, 2024 08:28
@domenkozar

Copy link
Copy Markdown
Member Author

Yeah those should work - any idea why linux packages were removed?

@turboMaCk

turboMaCk commented Apr 15, 2024

Copy link
Copy Markdown
Member

I did not try to investigate it but my first guess from:

       > npm ERR! [esbuild] Trying to download "https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.20.2.tgz"
       > npm ERR! [esbuild] Failed to download "https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.20.2.tgz": getaddrinfo EAI_AGAIN registry.npmjs.org

is that npm install (or post-install or so) tries to download the tgz from the internet which fails in the sandbox. I'm not sure why it needs to download it or what initiates that download. Maybe it could avoided. If not I think we can try to fetch this using nix and put them into the node_modules in patchPhase which might be enough for npm to skip trying to fetch these cowboy-style. Likely these are invisible to node2nix since npm allows any sort of user defined effect in the install phase.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 15, 2024
@domenkozar

Copy link
Copy Markdown
Member Author

We should try again

@domenkozar domenkozar mentioned this pull request Sep 27, 2024
@domenkozar domenkozar closed this Oct 2, 2024
zupo added a commit to teamniteo/nixpkgs that referenced this pull request Feb 15, 2025
Current elm-land in master is actually broken. It does build, but it
doesn't run. This commit rewrites it from node2nix to buildNpmPackage
and adds a test to confirm it runs.

Previus work:
* NixOS#344866
* NixOS#304198
* NixOS#267725

Refs Thaigersprint/thaigersprint-2025#1
@zupo zupo mentioned this pull request Feb 15, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants