Skip to content

genealogos: init at 1.0.0#309849

Merged
infinisil merged 1 commit intoNixOS:masterfrom
ErinvanderVeen:genealogos
Mar 19, 2025
Merged

genealogos: init at 1.0.0#309849
infinisil merged 1 commit intoNixOS:masterfrom
ErinvanderVeen:genealogos

Conversation

@ErinvanderVeen
Copy link
Member

@ErinvanderVeen ErinvanderVeen commented May 7, 2024

Description of changes

Genealogos is an CycloneDX SBOM Generator for Nix(pkgs).

https://github.com/tweag/genealogos

The repository contains multiple packages, the one packaged in this PR are:

  • genealogos-cli that provides the genealogos binary to create SBOMs from the terminal
  • genealogos-api, that provides the genealogos-api binary that sets up an api to create SBOMs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ErinvanderVeen ErinvanderVeen marked this pull request as draft May 7, 2024 14:17
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 7, 2024
@ofborg ofborg bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 13, 2024
@ErinvanderVeen ErinvanderVeen marked this pull request as ready for review May 13, 2024 09:44
@ErinvanderVeen ErinvanderVeen changed the title genealogos: init at 0.2.0 genealogos: init at 0.3.0 May 14, 2024
@ErinvanderVeen ErinvanderVeen requested a review from infinisil May 16, 2024 13:44
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@h0nIg
Copy link
Contributor

h0nIg commented Mar 17, 2025

@ErinvanderVeen any update to get this in?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 17, 2025
@ErinvanderVeen
Copy link
Member Author

ErinvanderVeen commented Mar 18, 2025

I'll rebase on master (and update to 1.0), but other than that, it just needs reviews.

@ErinvanderVeen ErinvanderVeen force-pushed the genealogos branch 2 times, most recently from e2d365c to bdadcb9 Compare March 18, 2025 10:57
@ErinvanderVeen ErinvanderVeen changed the title genealogos: init at 0.3.0 genealogos: init at 1.0.0 Mar 18, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 18, 2025
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge!

@infinisil infinisil merged commit 4babefd into NixOS:master Mar 19, 2025
27 checks passed
};

cargoLock = {
lockFile = ./Cargo.lock;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please useFetchCargoVendor.

@dotlambda
Copy link
Member

genealogos: init at 1.0.0

The commit message doesn't make sense. There is no such package.

# Since most tests were removed, just skip testing
doCheck = false;

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib; {
meta = {

#208242

doCheck = false;

meta = with lib; {
description = "A Nix sbom generator";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "A Nix sbom generator";
description = "Nix sbom generator";

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#meta-attributes

inherit (darwin.apple_sdk.frameworks) ApplicationServices Carbon Cocoa VideoToolbox;
};

inherit (callPackage ../development/tools/genealogos { }) genealogos-cli genealogos-api;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not pkgs/by-name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments