zig.hook: fix broken cache dir in impure devshells #310588
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: zig
ofborg
bot
added
10.rebuild-darwin: 11-100
bandithedoge
approved these changes
Aug 2, 2024
wegank
added
the
2.status: stale
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2309 |
stale
bot
removed
the
2.status: stale
nixpkgs-ci
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a fix for #270415 (comment).
To fix, we simply do not set
ZIG_GLOBAL_CACHE_DIRif we are inside an impure devshell.This approach is also followed by stdenv:
nixpkgs/pkgs/stdenv/generic/setup.sh
Line 806 in 5c0c6e1
Things done
For non-Linux: Is sandboxing enabled innix.conf? (See Nix manual)Tested, as applicable: …nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)