Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] xandikos: init at 0.0.6 #31096

Closed
wants to merge 4 commits into from
Closed

Conversation

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Nov 1, 2017

Motivation for this change

OwnCloud SUCKS so much for syncing calendar & contact data, fucks up my data every other day, does not allow creating collections from clients (using vdirsyncer) ... so I need an alternative.

Radicale is HELL when trying to set it up,...it just won't work as I request.

So this is another caldav/carddav server which claims to be compatible with my android sync client and vdirsyncer... hopefully it is.


Still waiting to get this issue: jelmer/xandikos#70 resolved, though

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

WIP!

@matthiasbeyer matthiasbeyer requested a review from nbp as a code owner Nov 1, 2017
@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

matthiasbeyer commented Nov 1, 2017

So it looks like dulwich gets build with fastimport, which is not python3 in nixpkgs, but xandikos needs/is python3.

Can someone tell me what to do?

@yegortimoshenko

This comment has been minimized.

Copy link
Member

yegortimoshenko commented Nov 1, 2017

Yeah, this derivation builds Xandikos with Python 2:

$ head -1 result/bin/.xandikos-wrapped 
#!/nix/store/5xl4sc0fv2gcj0cbnvxja14yl89nk5c6-python-2.7.14/bin/python2.7

Not sure what to do just yet. fastimport seems to be a test dependency of dulwich, so ideally it should not be pulled in...

@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

matthiasbeyer commented Nov 1, 2017

Issue solved. This works now, but I would like to add a service definition for this before it gets merged!

@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:add-xandikos branch to bcd546b Nov 1, 2017
@matthiasbeyer matthiasbeyer requested a review from FRidh as a code owner Nov 1, 2017
@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

matthiasbeyer commented Nov 1, 2017

Added a service definition, though I don't know how to test this properly or even implement VM tests for it.

Can someone jump in? 😄

nixos/modules/services/networking/xandikos.nix Outdated
type = types.bool;
default = true;
description = ''
AUtomatically create necessary directories.

This comment has been minimized.

Copy link
@FRidh
nixos/modules/services/networking/xandikos.nix Outdated
type = types.int;
default = 8080;
description = ''
Port to listen on

This comment has been minimized.

Copy link
@FRidh

FRidh Nov 1, 2017

Member

dot

nixos/modules/services/networking/xandikos.nix Outdated
default = "/";
description = ''
Path to Xandikos.
(useful when Xandikos is behind a reverse proxy)

This comment has been minimized.

Copy link
@FRidh

FRidh Nov 1, 2017

Member

No need for parentheses.

@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:add-xandikos branch to 4ec5a9f Nov 1, 2017
@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

matthiasbeyer commented Nov 1, 2017

Done. Still no tests, though.

@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

matthiasbeyer commented Nov 10, 2017

Can someone suggest how to test this?

@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:add-xandikos branch from f81dff4 to 43ea8d1 Feb 16, 2019
@matthiasbeyer matthiasbeyer requested a review from Infinisil as a code owner Feb 16, 2019
@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:add-xandikos branch from 43ea8d1 to 2df0761 May 2, 2019
@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:add-xandikos branch from 2df0761 to ca8b2b1 Jul 8, 2019
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@Infinisil

This comment has been minimized.

Copy link
Member

Infinisil commented Jul 13, 2019

https://github.com/pimutils/vdirsyncer seems like an easy way to test this.

@ivan

This comment has been minimized.

Copy link
Member

ivan commented Sep 6, 2019

For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated types.string, which emits a warning as of #66346. Before merging, please change this to another type, possibly:

  • types.str for a single string where merging does not make sense, or cannot work
  • types.lines for multi-line configuration or scripts where merging is possible
  • types.listOf types.str for a mergeable list of strings
@@ -340,6 +340,7 @@
cockroachdb = 313;
zoneminder = 314;
paperless = 315;
xandikos = 316;

This comment has been minimized.

Copy link
@0x4A6F

0x4A6F Nov 7, 2019

Contributor

Can we utilize systemd's DynamicUser here?

@matthiasbeyer matthiasbeyer deleted the matthiasbeyer:add-xandikos branch Nov 9, 2019
@0x4A6F 0x4A6F mentioned this pull request Dec 11, 2019
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.