Add nvidia-ctk with nvidia-container-toolkit #317199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick question: if this is seen as a bug, will this be backported to 24.05 or is it just added to nixpkgs unstable? |
|
Hello @rutrum, Thank you for your contribution. What is the main use case of having the nvidia-ctk mounted within the container? As far as I am aware, it's useful on the host side to configure CDI to properly set up the containerized environment. I weighted adding it inside the container, but I failed to see a reason to do so. The patch you provided effectively makes the Thanks! |
ereslibre
reviewed
Jun 14, 2024
| @@ -94,6 +94,8 @@ | |||
| containerPath = "/usr/bin/nvidia-debugdump"; } | |||
| { hostPath = lib.getExe' nvidia-driver "nvidia-powerd"; | |||
| containerPath = "/usr/bin/nvidia-powerd"; } | |||
| { hostPath = lib.getExe' nvidia-driver "nvidia-ctk"; | |||
There was a problem hiding this comment.
Suggested change
| { hostPath = lib.getExe' nvidia-driver "nvidia-ctk"; | |
| { hostPath = lib.getExe' pkgs.nvidia-container-toolkit "nvidia-ctk"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I think this is a bug fix. The nixos option hardware.nvidia-container-toolkit.mount-nvidia-executables states that nvidia-ctk would be added, but it is not. I believe this adds it.
Sorry this is my second attempt at a pull request because I was unsure how to change the upstream branch and squash commits. Thanks for your patience.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.