Skip to content

linkding: init at 1.36.0 - #341963

Closed
l0b0 wants to merge 3 commits into
NixOS:masterfrom
l0b0:linkding
Closed

linkding: init at 1.36.0#341963
l0b0 wants to merge 3 commits into
NixOS:masterfrom
l0b0:linkding

Conversation

@l0b0

@l0b0 l0b0 commented Sep 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of changes

From the project:

Self-hosted bookmark manager that is designed be to be minimal, fast, and easy to set up using Docker.

Closes #341665.

FYI @sissbruecker

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 15, 2024
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 15, 2024
@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Sep 15, 2024
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Sep 15, 2024
@trzpiot

trzpiot commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

I can take over the review for aarch64-darwin as soon as the PR is ready. 🙂

@l0b0
l0b0 force-pushed the linkding branch 3 times, most recently from 1304d4d to 714781b Compare October 9, 2024 02:53
@l0b0 l0b0 changed the title linkding: init at 1.33.0 linkding: init at 1.36.0 Oct 9, 2024
@l0b0
l0b0 marked this pull request as ready for review October 9, 2024 02:53
@l0b0
l0b0 requested a review from patka-123 October 9, 2024 02:54
@l0b0

l0b0 commented Oct 9, 2024

Copy link
Copy Markdown
Contributor Author

I can take over the review for aarch64-darwin as soon as the PR is ready. 🙂

Thanks! I can't see you in the list of possible reviewers, but feel free to look into aarch64-darwin support.

@patka-123
patka-123 removed their request for review October 11, 2024 11:36
@l0b0
l0b0 requested review from Thesola10, drupol, imincik and nh2 October 19, 2024 08:11
drupol
drupol requested changes Oct 19, 2024
View reviewed changes

@drupol drupol left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

The diff LGTM, except a few nits.

The PR must contain 2 commits ad minima:

  • 1 commit to add the package: linkding: init at 1.36.0
  • 1 commit to add the NixOS service: nixos/linkding: init (please verify in the contributor guide documentation how to format commit log messages correctly, I may be wrong here)

Since you're adding a new NixOS service, a release note entry must be added too.

Comment thread pkgs/by-name/li/linkding/package.nix Outdated
Comment thread pkgs/by-name/li/linkding/package.nix Outdated
Comment thread pkgs/by-name/li/linkding/package.nix Outdated
Comment thread pkgs/by-name/li/linkding/package.nix Outdated
Comment thread nixos/modules/services/web-apps/linkding.nix Outdated
@github-actions github-actions Bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels Oct 19, 2024
GaetanLepage
GaetanLepage reviewed Feb 2, 2025
View reviewed changes
Comment thread pkgs/development/python-modules/django-registration/default.nix Outdated
Comment thread pkgs/development/python-modules/django-registration/default.nix Outdated
Comment thread pkgs/development/python-modules/django-registration/default.nix Outdated
Comment thread pkgs/development/python-modules/django-registration/default.nix Outdated
Comment thread pkgs/development/python-modules/django-registration/default.nix Outdated
GaetanLepage
GaetanLepage reviewed Feb 2, 2025
View reviewed changes

@GaetanLepage GaetanLepage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, linkding 1.37.0 is out (it's ok to not bump it just yet).

Comment thread pkgs/by-name/li/linkding/package.nix Outdated
@ofborg ofborg Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 2, 2025
@ofborg ofborg Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 2, 2025
GaetanLepage
GaetanLepage reviewed Feb 2, 2025
View reviewed changes
Comment thread pkgs/by-name/li/linkding/package.nix Outdated
@github-actions github-actions Bot added the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Feb 2, 2025
@l0b0 l0b0 mentioned this pull request Feb 2, 2025
Merged
13 tasks
@FliegendeWurst

FliegendeWurst commented Feb 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Almost all tests fail with: (full log)

  - [pid=1621][err] Old Headless mode has been removed from the Chrome binary. Please use the new Headless mode (https://developer.chrome.com/docs/chromium/new-headless) or the chrome-headless-shell which is a standalone implementation of the old Headless mode (https://developer.chrome.com/blog/chrome-headless-shell).

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@FliegendeWurst FliegendeWurst mentioned this pull request Mar 16, 2025
Closed
@supermarin

supermarin commented May 6, 2025

Copy link
Copy Markdown
Contributor

@l0b0 need a hand pushing this one through? stumbled upon this one just now looking for linkding in nixos man. I rebased it in my fork supermarin@3ea6353 but not sure I can contribute the change here without opening a separate PR to nixpkgs. Feel free to reset on my tree and force push

@l0b0

l0b0 commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

@l0b0 need a hand pushing this one through? stumbled upon this one just now looking for linkding in nixos man. I rebased it in my fork supermarin@3ea6353 but not sure I can contribute the change here without opening a separate PR to nixpkgs. Feel free to reset on my tree and force push

Yes, please, I basically put this on indefinite pause.

@supermarin

supermarin commented May 7, 2025

Copy link
Copy Markdown
Contributor

@l0b0 no prob. want me to open a separate PR? don't think I can contribute to this one

@l0b0

l0b0 commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

@l0b0 no prob. want me to open a separate PR? don't think I can contribute to this one

Yeah, I don't think you can. Go for it, use as much as you like from this one.

@supermarin supermarin mentioned this pull request May 7, 2025
Closed
13 tasks
@supermarin

supermarin commented May 7, 2025

Copy link
Copy Markdown
Contributor

Sounds good I'll open a new one shortly. I saw there were a few releases since and I'll update it to 1.39. One thing that comes to my mind looking at this: does it make sense to duplicate every ENV setting in nix (might be long term maintenance burden) vs dynamically generate ENV from the module the fly? I see this much like how docker-compose based projects work

@fugidev

fugidev commented May 7, 2025

Copy link
Copy Markdown
Member

Sounds good I'll open a new one shortly. I saw there were a few releases since and I'll update it to 1.39. One thing that comes to my mind looking at this: does it make sense to duplicate every ENV setting in nix (might be long term maintenance burden) vs dynamically generate ENV from the module the fly? I see this much like how docker-compose based projects work

A freeform module would be better imo

@supermarin

supermarin commented May 8, 2025

Copy link
Copy Markdown
Contributor

ok so I spent a bit of time on this yesterday #404962, and I can't figure out why headless chromium is crashing on e2e tests. anyone has ideas?

@FliegendeWurst
FliegendeWurst marked this pull request as draft May 13, 2025 15:28
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 25, 2025
l0b0 and others added 3 commits August 1, 2025 11:13
@l0b0 @GaetanLepage
python312Packages.django-registration: init at 5.1.0
39fc872 
Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
@l0b0 @drupol
@FliegendeWurst @GaetanLepage
linkding: init at 1.36.0
548563b 
Helps with NixOS#341665.

Co-authored-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
Co-authored-by: Arne Keller <2012gdwu+github@posteo.de>
Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
@l0b0 @drupol
nixos/linkding: init
ab7e027 
Closes NixOS#341665.

Includes all relevant options
<https://linkding.link/options/#list-of-options>, leaving any options
with a `null`/`[]` default unset if not explicitly set to something
else.

Flips the semantics of some options to avoid double negatives in the
configuration.

Co-Authored-By: Pol Dellaiera <pol.dellaiera@protonmail.com>
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 1, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 15, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 28, 2026
@pyrox0

pyrox0 commented Apr 23, 2026

Copy link
Copy Markdown
Member

#509346 supercedes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage left review comments
@Thesola10 Thesola10 Awaiting requested review from Thesola10
@imincik imincik Awaiting requested review from imincik
@nh2 nh2 Awaiting requested review from nh2
@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst
@natsukium natsukium Awaiting requested review from natsukium
@drupol drupol Awaiting requested review from drupol

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package request: linkding

10 participants

@l0b0 @trzpiot @FliegendeWurst @supermarin @fugidev @pyrox0 @drupol @GaetanLepage @wegank @h7x4