New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looking-glass-client: init at a10 #34386

Merged
merged 1 commit into from Feb 2, 2018

Conversation

Projects
None yet
4 participants
@Pneumaticat
Contributor

Pneumaticat commented Jan 29, 2018

Motivation for this change

An application to relay frames from a KVM VFIO virtual machine (e.g. running Windows) to a window on the Linux host using shared memory.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc

This comment has been minimized.

Show comment
Hide comment
@grahamc

grahamc Jan 29, 2018

Member

@GrahamcOfBorg build looking-glass-client

Member

grahamc commented Jan 29, 2018

@GrahamcOfBorg build looking-glass-client

@GrahamcOfBorg

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘looking-glass-client-a10’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/virtualization/looking-glass-client/default.nix:30 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg

Success on x86_64-linux (full log)

Partial log (click to expand)

gcc -o bin/looking-glass-client .build/main.o .build/lg-renderer.o .build/spice/spice.o .build/renderers/opengl.o -lrt -Wl,--gc-sections -L/nix/store/rb4vsahgqn5q4nq5k01vfqi6aiin4ax8-libX11-1.6.5/lib -L/nix/store/jp8i5dski55f02cn2xiyw0dpb3xn8xi0-mesa-noglu-17.2.8/lib -L/nix/store/gjdf0gwada330nyjmnzyrnz5vbhscn5a-glu-9.0.0/lib -L/nix/store/pan0vwrvh40ciqfyjzrdjl9bxwbgc3jw-SDL2-2.0.7/lib -L/nix/store/v4g1iqhh5y35ccc73bs82flijyvva2ys-SDL2_ttf-2.0.14/lib -L/nix/store/j705knck72ps4gpzk2jiswxj5nibxnqv-openssl-1.0.2n/lib -L/nix/store/2x3ia1b25g1wbmyks1llh9ns9qha7chw-fontconfig-2.12.1-lib/lib -L/nix/store/giigsd4cy3mb40v67albhiwc63s9djjj-freetype-2.7.1/lib -lSDL2_ttf -Wl,-rpath,/nix/store/pan0vwrvh40ciqfyjzrdjl9bxwbgc3jw-SDL2-2.0.7/lib -Wl,--enable-new-dtags -lSDL2 -lGLU -lGL -lssl -lcrypto -lfontconfig -lfreetype -lX11
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9589wnn29z0f1p9rc5fjnxg33x9pn6ly-looking-glass-client-a10
shrinking /nix/store/9589wnn29z0f1p9rc5fjnxg33x9pn6ly-looking-glass-client-a10/bin/looking-glass-client
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9589wnn29z0f1p9rc5fjnxg33x9pn6ly-looking-glass-client-a10/bin 
patching script interpreter paths in /nix/store/9589wnn29z0f1p9rc5fjnxg33x9pn6ly-looking-glass-client-a10
checking for references to /tmp/nix-build-looking-glass-client-a10.drv-0 in /nix/store/9589wnn29z0f1p9rc5fjnxg33x9pn6ly-looking-glass-client-a10...
/nix/store/9589wnn29z0f1p9rc5fjnxg33x9pn6ly-looking-glass-client-a10

@GrahamcOfBorg

Failure on aarch64-linux (full log)

Partial log (click to expand)

gcc -c -g -O3 -std=gnu99 -march=native -Wall -Werror -I./ -I../common -DDEBUG -DATOMIC_LOCKING -ffast-math -fdata-sections -ffunction-sections -D_REENTRANT -I/nix/store/xn25kk9caf7zk6mbh8qgn2n58yp911df-xproto-7.0.31/include -I/nix/store/vigch5qpv3npz1ag242v8zf7ivmgypq5-libX11-1.6.5-dev/include -I/nix/store/1gl2k79lnqw532zb669rd16jwh39hca3-kbproto-1.0.7/include -I/nix/store/0hs365gafy1i2hdkm1q1qgh0z5m3v6x9-mesa-noglu-17.2.8-dev/include -I/nix/store/vsgbzdpsaixa17wg2pi44sr96vqgijjv-glu-9.0.0-dev/include -I/nix/store/dpy97pfjypxiilsb88dmk8c2va2cnadv-SDL2-2.0.7-dev/include/SDL2 -I/nix/store/5mmg1z9r5wyrnzfyr66gb0vw2nzwkpsh-SDL2_ttf-2.0.14/include/SDL2 -I/nix/store/sk5fk2pv7kg7vq1gjag3791hql2fg63d-openssl-1.0.2n-dev/include -I/nix/store/m2i1myz7sv5hiama0p29ch6phcdc68bb-spice-protocol-0.12.13/include/spice-1 -I/nix/store/z3m4gria37mw09609mzfrb6n3dp9j6f5-fontconfig-2.12.1-dev/include -I/nix/store/p88as78q8sdd15lkgk82npv4g23jw2rz-expat-2.2.5-dev/include -I/nix/store/mzgr9k3765dy4zjd4vpij70qpsj5rlq0-freetype-2.7.1-dev/include/freetype2 -DBUILD_VERSION='""' -o .build/renderers/opengl.o renderers/opengl.c
In file included from renderers/opengl.c:33:0:
../common/memcpySSE.h:24:23: fatal error: tmmintrin.h: No such file or directory
 #include <tmmintrin.h>
                       ^
compilation terminated.
make: *** [Makefile:28: .build/renderers/opengl.o] Error 1
make: *** Waiting for unfinished jobs....
builder for '/nix/store/cyyhkn96gfgackxgnpjvnrw099qq47c3-looking-glass-client-a10.drv' failed with exit code 2
error: build of '/nix/store/cyyhkn96gfgackxgnpjvnrw099qq47c3-looking-glass-client-a10.drv' failed

Show outdated Hide outdated pkgs/applications/virtualization/looking-glass-client/default.nix
Show outdated Hide outdated pkgs/applications/virtualization/looking-glass-client/default.nix
for legacy programs that require high performance graphics.
'';
homepage = https://looking-glass.hostfission.com/;
license = licenses.gpl2Plus;

This comment has been minimized.

@jtojnar

jtojnar Jan 29, 2018

Contributor

Do you have a source for this? The website only seems to talk about GPL 2:

https://looking-glass.hostfission.com/

@jtojnar

jtojnar Jan 29, 2018

Contributor

Do you have a source for this? The website only seems to talk about GPL 2:

https://looking-glass.hostfission.com/

This comment has been minimized.

@Pneumaticat

Pneumaticat Jan 29, 2018

Contributor

The main.c file of the client says "either version 2 of the License, or (at your option) any later version", so I assumed that meant GPL-2.0+.

@Pneumaticat

Pneumaticat Jan 29, 2018

Contributor

The main.c file of the client says "either version 2 of the License, or (at your option) any later version", so I assumed that meant GPL-2.0+.

@Pneumaticat

This comment has been minimized.

Show comment
Hide comment
@Pneumaticat

Pneumaticat Feb 2, 2018

Contributor

(Sorry for the code style issues, it's my first nix pull request :D)

Contributor

Pneumaticat commented Feb 2, 2018

(Sorry for the code style issues, it's my first nix pull request :D)

@jtojnar

This comment has been minimized.

Show comment
Hide comment
@jtojnar

jtojnar Feb 2, 2018

Contributor

Thanks, this looks good.

Contributor

jtojnar commented Feb 2, 2018

Thanks, this looks good.

@jtojnar jtojnar merged commit 93532b0 into NixOS:master Feb 2, 2018

1 check was pending

grahamcofborg-eval Checking new out paths
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment