init: Pebble sdk at 4.5 #35083

edanaher · 2018-02-17T20:26:10Z

Motivation for this change

While Pebble has been bought by Fitbit and stopped selling new products, the watches are still around and available (and cheap!). So this adds the pebble sdk to develop apps for it.

After the initial PR (#23445) languished and was eventually closed, here's a fresh one. (It's been a good learning experience for me in the Right Way to do several things :) )

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Caught by travis-ci; nicely done!

- peewee - pypng - progressbar2 - pyqrcode - wsgiref

- Don't require exact versions of python packages - Use existing python packages where appropriate - Use pythonEnv to set up the python dependencies - Other minor cleanups

Thanks for the PR comment, c0bw3b.

dotlambda · 2018-02-18T08:57:38Z

pkgs/top-level/python-packages.nix

@@ -5897,6 +5897,23 @@ in {
    };
  };

+  peewee = buildPythonPackage rec {


Please put this in pkgs/development/python-modules and use callPackage.
The same is true for the other 3 Python modules.

dotlambda · 2018-02-18T08:58:25Z

pkgs/top-level/python-packages.nix

@@ -5897,6 +5897,23 @@ in {
    };
  };

+  peewee = buildPythonPackage rec {
+    name = "peewee-2.8.8";


No name. Specify pname and version instead.

dotlambda · 2018-02-18T08:58:33Z

pkgs/top-level/python-packages.nix

@@ -6101,6 +6118,20 @@ in {

  pyphen = callPackage ../development/python-modules/pyphen {};

+  pypng = buildPythonPackage rec {
+    name = "pypng-0.0.18";


No name. Specify pname and version instead.

dotlambda · 2018-02-18T08:58:41Z

pkgs/top-level/python-packages.nix

@@ -6101,6 +6118,20 @@ in {

  pyphen = callPackage ../development/python-modules/pyphen {};

+  pypng = buildPythonPackage rec {
+    name = "pypng-0.0.18";
+    src = pkgs.fetchurl {


fetchPypi

dotlambda · 2018-02-18T08:58:58Z

pkgs/top-level/python-packages.nix

@@ -5897,6 +5897,23 @@ in {
    };
  };

+  peewee = buildPythonPackage rec {
+    name = "peewee-2.8.8";
+    src = pkgs.fetchurl {


fetchPypi

dotlambda · 2018-02-18T09:06:35Z

pkgs/development/mobile/pebblesdk/pebble-libs.nix

+      wsgiref
+    ];
+
+    patchPhase = ''


dotlambda · 2018-02-18T09:08:15Z

pkgs/development/mobile/pebblesdk/pebble-libs.nix

+    name = "${pname}-${version}";
+    pname = "libpebble2";
+    version = "0.0.26";
+    src = python27Packages.fetchPypi {


If this is even on PyPI, why didn't you put it in python-packages.nix?

dotlambda · 2018-02-18T09:08:42Z

pkgs/development/mobile/pebblesdk/pebble-libs.nix

+      sha256 = "16n69xxma7k8mhl8birdwa0fsqvf902g08s80mjb477s4dcxrvaz";
+    };
+
+    # Tries and fails to pull in pytest-mock


checkInputs = [ pytest-mock ]

dotlambda · 2018-02-18T09:10:43Z

pkgs/development/mobile/pebblesdk/default.nix

+    homepage = https://developer.pebble.com/sdk;
+    description = "SDK to build applications for the Pebble smartwatch";
+
+    license = https://developer.pebble.com/legal/sdk-license/;


This should probably be licenses.unfree, shouldn't it?
You can put the URL in a comment.

dotlambda · 2018-02-18T09:12:16Z

pkgs/top-level/python-packages.nix

+
+    meta = {
+      description = "A QR code generator written purely in Python with SVG, EPS, PNG and terminal output";
+      home = "https://pypi.python.org/pypi/PyQRCode/";


homepage, no quotes. And the homepage should be https://github.com/mnooner256/pyqrcode.

dotlambda

Please also make all changes requested in #23445.

edanaher · 2018-02-18T13:27:00Z

sigh; I forgot to push my final two changes wrapping up comments from #23445. Those should be good now; I'll look at the rest of your comments in a bit.

edanaher · 2018-02-23T20:46:15Z

@dotlambda Thanks for all the feedback; I think I've addressed it all, along with a couple other minor cleanups. Two areas I'd appreciate feedback:

It looks like libpebble and peewee don't put their tests in the pypi distribution; I'm not entirely sure whether it's better to be simple and disable the tests, or pull the source from github and enable them
progressbar2 version 3 made some breaking changes, so I'm building progressbar2 version 2.7.3 (the latest 2.x version I could find). I'm not sure if that should be in pebble-libs or if I should add it to python-packages in case other packages also need it.

dotlambda · 2018-02-27T01:08:13Z

Better fetch from GitHub and, if you like, raise an upstream issue about including tests on PyPI.
I think you should add libpebble2 to the python package set (using callPackage from python-packages.nix). You can then override the progressbar2 version like so: https://github.com/peterhoeg/nixpkgs/blob/master/pkgs/servers/home-assistant/default.nix#L8 and create a pypkjs.nix file which you call just like frontend.nix in the example.

dotlambda · 2018-03-19T10:23:11Z

@edanaher Any progress?

edanaher · 2018-03-19T14:36:29Z

In the process of pulling out and testing pypkjs, I discovered that the emulator isn't working again; I was looking at that, and got distracted. I'll take another shot at fixing it up.

FRidh · 2019-01-06T12:28:46Z

Closing due to inactivity. If you still want this in, either request for this to be reopened or open a new PR.

Evan Danaher and others added 9 commits February 17, 2018 13:34

init: pebble-sdk at 4.5

c7ddc6f

pebble-sdk: Add exec-phonesim.patch

b1ad928

Caught by travis-ci; nicely done!

python-packages: Add libraries required for pebble-sdk

50173e1

- peewee - pypng - progressbar2 - pyqrcode - wsgiref

pebble-sdk: cleanups from code review

d893243

- Don't require exact versions of python packages - Use existing python packages where appropriate - Use pythonEnv to set up the python dependencies - Other minor cleanups

pebble-sdk: Cleanups from a few months of nixpkgs changes.

cef13e2

pebble-sdk: Use fetchPypi for libpebble2.

df7b336

Thanks for the PR comment, c0bw3b.

pyqrcode: Fix license and use fetchPypi.

c5fbc06

pebble-sdk: Minor cleanups from PR comments

ef9e3e3

Move new python libraries into python-modules, minor cleanups.

42b1577

edanaher requested a review from FRidh as a code owner February 17, 2018 20:26

GrahamcOfBorg added the 6.topic: python label Feb 17, 2018

dotlambda requested changes Feb 18, 2018

View reviewed changes

pebble-sdk: Use old progressbar2; version 3 isn't backwards compatible.

ea0424a

edanaher force-pushed the pebble-sdk branch from b3eeea8 to 4a327a0 Compare February 23, 2018 19:48

pebble-sdk: Cleanups from PR comments.

1051cc3

edanaher force-pushed the pebble-sdk branch from 4a327a0 to 1051cc3 Compare February 23, 2018 19:50

edanaher added 2 commits February 23, 2018 14:57

Trivial cleanups from self-review.

bb0022a

s/stdenv.lib/lib/. Thanks, GrahamcOfBorg :)

c553106

GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 23, 2018

samueldr added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 11, 2018

FRidh closed this Jan 6, 2019

Sorixelle mentioned this pull request Jul 30, 2020

pebble-sdk: init at 4.5 #94235

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

init: Pebble sdk at 4.5 #35083

init: Pebble sdk at 4.5 #35083

edanaher commented Feb 17, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda Feb 18, 2018

dotlambda left a comment

edanaher commented Feb 18, 2018

edanaher commented Feb 23, 2018

dotlambda commented Feb 27, 2018

dotlambda commented Mar 19, 2018

edanaher commented Mar 19, 2018

FRidh commented Jan 6, 2019

init: Pebble sdk at 4.5 #35083

init: Pebble sdk at 4.5 #35083

Conversation

edanaher commented Feb 17, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda left a comment

Choose a reason for hiding this comment

edanaher commented Feb 18, 2018

edanaher commented Feb 23, 2018

dotlambda commented Feb 27, 2018

dotlambda commented Mar 19, 2018

edanaher commented Mar 19, 2018

FRidh commented Jan 6, 2019