-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyter: add ijavascript kernel #35290
Conversation
This change enables us to call toPythonModules in package definitions. Cfr following commit: 'jupyter: init standalone package'
This is a meta package for creating a jupyter notebook kernel definition folder. It must be used in conjunction with jupyter or jupyterhub to make different environements availables.
The diff is fine, there is no sane way to handle the complexity of npm modules. |
I'm glad to see it works with another language. |
3be5555
to
c845453
Compare
I upgraded it to a Node 8 package because a user probably wants the latest feature in the REPL.
Agreed, but I lack the Nix knowledge to know how. |
41ba684
to
343b597
Compare
This needs to be rebased. If you still want to get this in, please open a new PR. |
Motivation for this change
Added the IJavascript Jupyter Notebook kernel to the (so far unmerged) pull request #33673 by @aborsu
I added a
javascript
kernel topkgs/development/misc/jupyterKernels/default.nix
which requires the packagenodePackages.ijavascript
.Following the steps of the npm packaging documentation, I added the
ijavascript
package topkgs/development/node-packages/node-packages-v6.json
and added build input overrides inpkgs/development/node-packages/default-v6.nix
because the package depends on node-gyp and zeromq.Then I ran the
generate.sh
script. Unfortunately it generated a huge diff of thenode-packages-v?.nix
files.I tested the updated module with this configuration:
Both python3 and javascript notebooks run fine.
Note that
proxyWebsockets = true
is required else the browser will fail to connect to the notebook. I discovered it by enabling debug logging in the nixos jupyter service.NPM dependencies for the notebook need to be installed into the
notebookDir
.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)