Add autokey application #35392
Add autokey application #35392
Conversation
| @@ -598,6 +598,8 @@ with pkgs; | |||
|
|
|||
| autorevision = callPackage ../tools/misc/autorevision { }; | |||
|
|
|||
| autokey = callPackage ../tools/x11/autokey { }; | |||
There was a problem hiding this comment.
Looks like it should be X11 not x11.
| propagatedBuildInputs = with python3Packages; [ xlib pyinotify dbus-python ]; | ||
|
|
||
| pythonPath = with python3Packages; | ||
| [ dbus-python ]; |
There was a problem hiding this comment.
It's probably sufficient to only add dbus-python in propagatedBuildInputs.
| python3Packages.buildPythonApplication rec { | ||
| pname = "autokey"; | ||
| version = "0.94.0"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
When using buildPythonApplication and buildPythonPackage the name attribute defaults to `"${pname}-${version}"' so this live can be removed.
| version = "0.94.0"; | ||
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
You should use fetchPypi or fetchFromGitHub.
| pythonPath = with python3Packages; | ||
| [ dbus-python ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Are you willing to maintain this package?
If so please add yourself to lib/maintainers.nix and reference yourself in meta.maintainers.
There was a problem hiding this comment.
Once i get my head round nix expressions and packaging i would gladly maintain this package as i use it daily.
| @@ -0,0 +1,24 @@ | |||
| { stdenv, fetchurl, python3Packages }: | |||
There was a problem hiding this comment.
Could you please replace callPackage in all-packages.nix with python3Packages.callPackage and explicitly declare all inputs to the derivation in the function arguments?
With that I mean replace the line { stdenv, fetchurl, python3Packages }: with { stdenv, fetchurl, xlib, pyinotify, dbus-python, buildPythonApplication }:.
There was a problem hiding this comment.
Thank you the package starts building but fails due to dbus-python not being found, which is why i had dbus-python in buildinputs but no sucess
|
close due to inaction? |
Yes im not using nixpkgs anymore. |
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
To add the text expander autokey
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)