Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsdcc: init at unstable-2018-02-24 #35463

Closed
wants to merge 4 commits into from
Closed

Conversation

@bignaux
Copy link
Contributor

@bignaux bignaux commented Feb 24, 2018

Motivation for this change

This provides only zsdcc and zsdcpp for z88dk. Not conflict with sdcc.
@bjornfor : can you have a look please since you are sdcc derivation maintainer ?

Things done

tested with z88dk example.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Bignaux Ronan added 2 commits Feb 23, 2018
Bignaux Ronan added 2 commits Feb 24, 2018
@bignaux bignaux changed the title zsdcc: init at Unstable-20180224 zsdcc: init at unstable-2018-02-24 Feb 24, 2018
@jtojnar jtojnar requested a review from bjornfor Feb 28, 2018
@@ -0,0 +1,48 @@
{ stdenv, sdcc, fetchFromGitHub, ... }:

This comment has been minimized.

@bjornfor

bjornfor Feb 28, 2018
Contributor

Please remove ... and list each needed input explicitly.

This comment has been minimized.

@bignaux

bignaux Mar 10, 2018
Author Contributor

will i not lost the interest of derivate sdcc doing that ?

This comment has been minimized.

@bjornfor

bjornfor Jun 11, 2019
Contributor

I don't understand that question.


sdcc.overrideAttrs (oldAttrs: rec {
version = "2018-02-24";
name = "zsdcc-unstable-${version}"; # ${oldAttrs.version}

This comment has been minimized.

@bjornfor

bjornfor Feb 28, 2018
Contributor

I'm not happy about packaging unstable versions. To me, that means it's not ready for Nixpkgs / end users.

This comment has been minimized.

@bignaux

bignaux Mar 10, 2018
Author Contributor

there is no release of zsdcc, and it's not target end users, but users of z88dk that wants to work with new clibs.

version = "2018-02-24";
name = "zsdcc-unstable-${version}"; # ${oldAttrs.version}

meta = oldAttrs.meta // {

This comment has been minimized.

@bjornfor

bjornfor Feb 28, 2018
Contributor

The "meta" section is usually at the end of the file.

Copy link
Contributor

@bjornfor bjornfor left a comment

See inline comments.

@bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Feb 28, 2018

Oh, and please squash the commits. (It looks like only one logical change to me.)

@aanderse
Copy link
Contributor

@aanderse aanderse commented May 21, 2019

@bignaux are you able to address the comments above?

@wamserma
Copy link
Contributor

@wamserma wamserma commented May 8, 2020

This PR seems abandoned. @bignaux would you mind closing?

@aanderse
Copy link
Contributor

@aanderse aanderse commented May 9, 2020

Easy enough to reopen PR if there is interest again.

@aanderse aanderse closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.