Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scriptcommunicator: init at 05.10 #36747

Closed
wants to merge 1 commit into from
Closed

Conversation

@bignaux
Copy link
Contributor

@bignaux bignaux commented Mar 10, 2018

Motivation for this change

new

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Are you still interested in getting this merged?
Please have a look at my comments. When it builds we can check whether it works as expected.

@bignaux bignaux changed the title [WIP] scriptcommunicator: init at 05.07 scriptcommunicator: init at 05.10 Apr 28, 2019
@bignaux
Copy link
Contributor Author

@bignaux bignaux commented Apr 28, 2019

@GrahamcOfBorg : build scriptcommunicator

sourceRoot = "source/ScriptCommunicator";

buildPhase = ''
cd DeleteFolder/DeleteFolder
Copy link
Member

@JohnAZoidberg JohnAZoidberg Apr 28, 2019

Do you have to cd into the directories for qmake to work?
If you have to, I think you could use qmake -r DeleteFolder.pro ScriptEditor.pro ScriptCommunicator.pro

Copy link
Contributor Author

@bignaux bignaux May 1, 2019

No way, i don't success to do that.

Copy link
Member

@aanderse aanderse May 21, 2019

pushd and popd might be a bit nicer to use here

Copy link
Member

@aanderse aanderse May 25, 2019

@bignaux ping

Copy link
Contributor Author

@bignaux bignaux May 25, 2019

i don't have time to make a perfect recipe for this bugging tool. I improve derivation on new release, time to time. Better is the enemy of good.

Copy link
Member

@aanderse aanderse May 25, 2019

@bignaux no worries. Just trying to be helpful and promote consistent coding style within nixpkgs.

cp ScriptCommunicator $out/share/scriptcommunicator/
cp documentation/Manual_ScriptCommunicator.pdf $out/share/scriptcommunicator/
makeWrapper $out/share/scriptcommunicator/ScriptCommunicator $out/bin/scriptcommunicator \
Copy link
Member

@JohnAZoidberg JohnAZoidberg Apr 28, 2019

Why not copy directly to $out/bin and wrap with wrapProgram $out/bin/Scriptcommunicator --[args]?

# Need to fix this - i don't populate with it for now.
#cp aardvarkI2cSpi/aardvark.so cheetahSpi/cheetah.so $out/lib/
cp -a ScriptEditor/apiFiles exampleScripts images templates test $out/share/scriptcommunicator
Copy link
Member

@JohnAZoidberg JohnAZoidberg Apr 28, 2019

Do we need test? Do you know what they do or how to run them?

Copy link
Contributor Author

@bignaux bignaux Apr 28, 2019

anyway if we would test really , we need special hardware, plus i think cheetahspi is closed source and globally, this scriptcommunicator is not written by a developer using linux so things are a bit ugly on the build system. If people need it, he has to write some PR. i find this tool very interesting in the feature (qt script, qt ui and so) and i think 99% of possible user on nixos would use it for simple serial that i test. So no really harmful.

Copy link
Member

@JohnAZoidberg JohnAZoidberg Apr 28, 2019

Yeah, I noticed - it's rough...
Sure, I'd be happy if you can confirm that the main functionality works.
I'd change the commend to something like # Cheetah and its wrapper are proprietary libraries and need special hardware

Copy link
Contributor Author

@bignaux bignaux May 1, 2019

fixed according to author.

@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Apr 28, 2019

Builds and runs for me :)
I don't have any serial hardware though - have you tried if it actually does the right thing?

pkgs/tools/misc/scriptcommunicator/default.nix Outdated Show resolved Hide resolved
@bignaux
Copy link
Contributor Author

@bignaux bignaux commented May 1, 2019

Please merge it like it is for the moment, i'll improve later with help of the author.

@stale
Copy link

@stale stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale label Jun 2, 2020
@bignaux bignaux closed this Oct 13, 2020
@bignaux bignaux deleted the scriptcomm branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants