Merged
Conversation
799b123 to
525cb13
Compare
Member
Author
Don't quite know why the CI is failing. I thought that GitHub URLs were allowed in the restricted eval mode, but also haven't contributed much in a while. There's plenty of other packages that use |
d866d1a to
afe7b14
Compare
Member
Author
|
I didn't know that fetchers need to be fixed-output derivations in Nixpkgs. Thanks to @Lassulus for the hint! |
afe7b14 to
777238e
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This packages the USBKVM desktop application, a GTK application to control a USB keyboard, video and mouse adapter based around the MS2109 HDMI to USB capture IC.
I initially packaged the Git source, building the device firmware as part of the Nix build process. However, this led to issues with an old version of the
gcc-arm-embeddedpackage with broken LTO, which ended up soft-bricking my device. Furthermore, the USBKVM developer (@carrotIndustries) kindly requested to package the release tarball instead of the source, as this contains a known-good device firmware version. I'm happy to add an option to build from source in addition to the tarball, if that's reasonable for Nixpkgs.This was packaged based on initial work done by @rubenhoenle. I can add them as a co-maintainer if they'd like.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.