Skip to content

usbkvm: init at 0.1.0#369115

Merged
Lassulus merged 1 commit intoNixOS:masterfrom
lschuermann:dev/usbkvm-init-0.1.0
Dec 29, 2024
Merged

usbkvm: init at 0.1.0#369115
Lassulus merged 1 commit intoNixOS:masterfrom
lschuermann:dev/usbkvm-init-0.1.0

Conversation

@lschuermann
Copy link
Member

@lschuermann lschuermann commented Dec 29, 2024

This packages the USBKVM desktop application, a GTK application to control a USB keyboard, video and mouse adapter based around the MS2109 HDMI to USB capture IC.

I initially packaged the Git source, building the device firmware as part of the Nix build process. However, this led to issues with an old version of the gcc-arm-embedded package with broken LTO, which ended up soft-bricking my device. Furthermore, the USBKVM developer (@carrotIndustries) kindly requested to package the release tarball instead of the source, as this contains a known-good device firmware version. I'm happy to add an option to build from source in addition to the tarball, if that's reasonable for Nixpkgs.

This was packaged based on initial work done by @rubenhoenle. I can add them as a co-maintainer if they'd like.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lschuermann lschuermann force-pushed the dev/usbkvm-init-0.1.0 branch 2 times, most recently from 799b123 to 525cb13 Compare December 29, 2024 13:51
@lschuermann
Copy link
Member Author

error: access to URI 'https://github.com/carrotIndustries/usbkvm/releases/download/v0.1.0/usbkvm-v0.1.0.tar.gz' is forbidden in restricted mode

Don't quite know why the CI is failing. I thought that GitHub URLs were allowed in the restricted eval mode, but also haven't contributed much in a while. There's plenty of other packages that use builtins.fetchurl with a GitHub release URL. Do you need to be a trusted user to allow this source to be fetched?

@lschuermann lschuermann force-pushed the dev/usbkvm-init-0.1.0 branch 2 times, most recently from d866d1a to afe7b14 Compare December 29, 2024 14:22
@lschuermann
Copy link
Member Author

I didn't know that fetchers need to be fixed-output derivations in Nixpkgs. Thanks to @Lassulus for the hint!

@lschuermann lschuermann force-pushed the dev/usbkvm-init-0.1.0 branch from afe7b14 to 777238e Compare December 29, 2024 14:24
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 29, 2024
@Lassulus Lassulus merged commit 1a7de5d into NixOS:master Dec 29, 2024
@lschuermann lschuermann mentioned this pull request Jan 6, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants